This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[WIP][MXNET-107] Fused LSTM implementation for CPU #10104
Merged
Merged
Changes from 2 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
fd24ed2
register RNN fused-API with nnvm, finish single-layer && undirection …
ba0fe6d
fix coding style and lint complains
TaoLv a3c34ab
add single-layer && undirectional LSTM backward function
b5c1ef7
make interface universal for other RNN mode
73ed6dd
share intermediate result between forward and backward in a trick way
d72fe17
add comments for important parameters
d6811b5
modify testcase
d0306e5
Fix coding style and error message
TaoLv c2e7c8f
fix openmp collapse error
154aa3b
fix const
7c0cc29
remove rnn.cu and skip related testcases temporarily for building on GPU
b59f009
support multi-layer and bidirectional for lstm inference
26d32d2
remove some testcaseS in test_gluon_rnn.py to build on GPU
1b89cff
remove testcase between fp32 and fp64 temporarily
afd831d
retrigger ci
TaoLv ce818d3
fix some logs
f24ee4b
use a better way to share memory
d51dafd
fix cudnn registration
cdaadf7
fix invariant calculations and enable some gpu testcases
4161f3b
add thread local cache for cudnn rnn op
TaoLv f3dcb07
add thread local cache for rnn op
09f6e9a
fix bugs
c28bbc8
remove some testcases to check segmentfault
3370cb4
remove cudnn registeration to check segmentfault
46af847
support multi-layer for LSTM Training
e42e7f9
modify lstm testcase
e5b8b51
add bidirectional support for lstm
8a67315
fix gluon and coding style
78edb41
fix bugs
f50f5c0
remove nnvm registration
35a4a4b
enable gpu testcases
19ef217
add detailed descriptions
b0cfcf8
add dropout check
b6b567e
fix workspace size
1471836
Merge remote-tracking branch 'upstream/master' into lstm
TaoLv a52b5ef
dropout is not supported, add unit test for it
TaoLv a60de72
Merge remote-tracking branch 'upstream/master' into lstm
TaoLv 3c61b84
fix review comments
TaoLv aeb8e9d
Merge remote-tracking branch 'upstream/master' into lstm
TaoLv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent approach! This will ensure we don't miss it to re-enable the test when we introduce dropout. Great job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Also to ensure the failure happens at a proper position and correct error message is presented. Follow @reminisce 's idea in PR 10844 .