Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-247] Always build profiler #10308

Merged
merged 4 commits into from
Apr 1, 2018
Merged

[MXNET-247] Always build profiler #10308

merged 4 commits into from
Apr 1, 2018

Conversation

cjolivier01
Copy link
Member

@cjolivier01 cjolivier01 commented Mar 28, 2018 •
edited
Loading

Description

https://issues.apache.org/jira/browse/MXNET-247

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@cjolivier01 cjolivier01 requested a review from szha as a code owner March 28, 2018 23:34
@cjolivier01 cjolivier01 changed the title Always build profiler [MXNET-247] Always build profiler Mar 28, 2018
@cjolivier01 cjolivier01 mentioned this pull request Mar 28, 2018
Merged
7 tasks
@marcoabreu
Copy link
Contributor

marcoabreu commented Mar 29, 2018 •
edited
Loading

Would enabling the compilation of the profiler harm the runtime performance?

marcoabreu
marcoabreu suggested changes Mar 29, 2018
View reviewed changes
Copy link
Contributor

@marcoabreu marcoabreu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the compile flag 'USE_PROFILER=1' in ci/docker/runtime_functions.sh

@cjolivier01
Copy link
Member Author

@marcoabreu this is covered in the JIRA: https://issues.apache.org/jira/browse/MXNET-247

@marcoabreu
Copy link
Contributor

Ah thank you, didn't see that. That's great!

marcoabreu
marcoabreu approved these changes Mar 29, 2018
View reviewed changes
Copy link
Contributor

@marcoabreu marcoabreu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I like that we can now change it during runtime without recompilation :)

@piiswrong piiswrong merged commit 121adb6 into apache:master Apr 1, 2018
@piiswrong
Copy link
Contributor

@cjolivier01 BTW, please remember to write the profiler doc page

lanking520 pushed a commit to lanking520/incubator-mxnet that referenced this pull request Apr 2, 2018
@cjolivier01 @lanking520
[MXNET-247] Always build profiler (apache#10308)
00cb732 
* Always build profiler

* Update naive_engine.cc

* remove PROFILE_MESSAGE macro

* Remove USE_PROFILER=1 from CI runs
haojin2 pushed a commit to haojin2/incubator-mxnet that referenced this pull request Apr 2, 2018
@cjolivier01
[MXNET-247] Always build profiler (apache#10308)
66bc0c7 
* Always build profiler

* Update naive_engine.cc

* remove PROFILE_MESSAGE macro

* Remove USE_PROFILER=1 from CI runs
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
@cjolivier01 @piiswrong
[MXNET-247] Always build profiler (apache#10308)
9d63f38 
* Always build profiler

* Update naive_engine.cc

* remove PROFILE_MESSAGE macro

* Remove USE_PROFILER=1 from CI runs
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
@cjolivier01 @zheng-da
[MXNET-247] Always build profiler (apache#10308)
431eb5c 
* Always build profiler

* Update naive_engine.cc

* remove PROFILE_MESSAGE macro

* Remove USE_PROFILER=1 from CI runs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marcoabreu marcoabreu marcoabreu approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjolivier01 @marcoabreu @piiswrong