Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

fix rnn #10954

Merged
merged 1 commit into from
May 15, 2018
Merged

fix rnn #10954

merged 1 commit into from
May 15, 2018

Conversation

szha
Copy link
Member

@szha szha commented May 15, 2018

Description

Fix gluon RNN layer problem from #10104 when dropout is turned on.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • fix the condition for forward_kernel in gluon rnn layer.

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@piiswrong piiswrong merged commit 65061dc into apache:master May 15, 2018
@szha szha deleted the rnn_fix branch May 15, 2018 21:34
jinhuang415 pushed a commit to jinhuang415/incubator-mxnet that referenced this pull request May 29, 2018
@szha
fix rnn (apache#10954)
8017a5f
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
@szha @piiswrong
fix rnn (apache#10954)
1213bd1
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
@szha @zheng-da
fix rnn (apache#10954)
1bb6d7f
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szha @piiswrong