[MXNET-922] Fix memleak in profiler

[KellenSunderland]

Description

Fix a memleak reported locally by ASAN during a normal inference test.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

• The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
• Changes are complete (i.e. I finished coding on this PR)
• All changes have test coverage:
• Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
• Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
• Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
• Code is well-documented:
• For user-facing API changes, API doc string has been updated.
• For new C++ functions in header files, their functionalities and arguments are documented.
• For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
• Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
• To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

[KellenSunderland]

@mxnet-label-bot can please add [pr-awaiting-review]

[lebeg]

std::default_delete<DeviceStats[]> is default and not needed explicitly, I think

[KellenSunderland]

Good point Anton, thanks. I'll double check just to be sure it's not needed.

…

On Mon, Sep 17, 2018, 4:44 AM Anton Chernov ***@***.***> wrote: ***@***.**** approved this pull request. ------------------------------ In src/profiler/profiler.h <#12499 (comment)> : > @@ -455,7 +455,7 @@ class Profiler { /*! \brief filename to output profile file */ std::string filename_ = "profile.json"; /*! \brief profile statistics consist of multiple device statistics */ - DeviceStats* profile_stat; + std::unique_ptr<DeviceStats[], std::default_delete<DeviceStats[]>> profile_stat; std::default_delete<DeviceStats[]> is default and not needed explicitly, I think — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#12499 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHGTEyHAcAMM20gltWP2DUxI2CDpFHPJks5ub2DhgaJpZM4Whorh> .

[KellenSunderland]

@lebeg Indeed it wasn't needed. I must have read the docs wrong. Simplified the code and rebased.

[KellenSunderland]

@marcoabreu This one should be ready to merge.