Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-913] Java API --- Scala NDArray Macros #12608

Closed
wants to merge 3 commits into from

Conversation

lanking520
Copy link
Member

@lanking520 lanking520 commented Sep 20, 2018

Description

This PR is to create a new set of Java-compatible Scala API with null as a default params.
@andrewfayres @nswamy @zachgk @yzhliu
Example:

NDArray nd2 = NDArray.japi().norm(nd, null, null, null, null).get();

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@stu1130
Copy link
Contributor

stu1130 commented Sep 20, 2018

Thanks for the contribution @lanking520
@mxnet-label-bot[pr-awaiting-review]

@marcoabreu marcoabreu added the pr-awaiting-review PR is waiting for code review label Sep 20, 2018
@vandanavk
Copy link
Contributor

Adding @andrewfayres @piyushghai for review too

@vrakesh
Copy link
Contributor

vrakesh commented Oct 9, 2018

@piyushghai requesting to review and merge this PR , it seems ready to merge

@lanking520
Copy link
Member Author

Stop the experiment and ship with this solution #12772

@lanking520 lanking520 closed this Oct 9, 2018
@lanking520 lanking520 deleted the java-ndmacros branch December 13, 2018 01:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants