Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

allow custom path and static linking for custom mallocs in make #12645

Merged
merged 2 commits into from
Sep 24, 2018
Merged

allow custom path and static linking for custom mallocs in make #12645

merged 2 commits into from
Sep 24, 2018

Conversation

szha
Copy link
Member

@szha szha commented Sep 23, 2018

Description

allow custom path and static linking for custom mallocs

Checklist

Essentials

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • To my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • allow and prefer custom path for custom mallocs
  • add search for .a for static linking of custom mallocs

eric-haibin-lin
eric-haibin-lin suggested changes Sep 23, 2018
View reviewed changes
Makefile
endif
endif
else
ifeq ($(USE_JEMALLOC), 1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add USE_JEMALLOC_PATH to make/config.mk? Otherwise people won't notice there's such option

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@eric-haibin-lin eric-haibin-lin merged commit c93c78e into apache:master Sep 24, 2018
@leezu leezu mentioned this pull request Oct 2, 2018
Merged
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eric-haibin-lin eric-haibin-lin eric-haibin-lin requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szha @eric-haibin-lin