Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

remove extra windows/mkldnn build flags #13635

Closed
wants to merge 1 commit into from

Conversation

azai91
Copy link
Contributor

@azai91 azai91 commented Dec 13, 2018

Description

Remove extra line in make to build mkldnn on windows. (#13628)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@azai91 azai91 requested a review from szha as a code owner December 13, 2018 08:59
@azai91
Copy link
Contributor Author

azai91 commented Dec 13, 2018

@ZhennanQin

@ZhennanQin
Copy link
Contributor

LGTM

@roywei
Copy link
Member

roywei commented Dec 14, 2018

@mxnet-label-bot add[Build]
@azai91 Thanks for the contribution, could you resolve the conflict?

@sandeep-krishnamurthy
Copy link
Contributor

@azai91 - Can you please rebase?

@anirudhacharya
Copy link
Member

@azai91 can you please resolve the conflicts on this PR?

@sandeep-krishnamurthy
Copy link
Contributor

@azai91 - Is this PR still necessary?

@azai91
Copy link
Contributor Author

azai91 commented Jan 28, 2019

nope. closing ticket.

@azai91 azai91 closed this Jan 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants