This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[MXNET-891] Support tuple of scales in upsample operator #15811
Open
benhe2011
wants to merge
91
commits into
apache:master
Choose a base branch
from
benhe2011:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
vandanavk
reviewed
Aug 8, 2019
… given in the scale tuple
samskalicky
reviewed
Aug 23, 2019
Is there a test somewhere that you test upsample using a scalar instead of a tuple? |
samskalicky
approved these changes
Aug 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
benhe2011
commented
Aug 23, 2019
Yes, in tests/python/unittest/test_operator.py line 1615 |
5 tasks
apeforest
reviewed
Aug 26, 2019
apeforest
reviewed
Aug 27, 2019
apeforest
reviewed
Aug 27, 2019
apeforest
reviewed
Aug 27, 2019
apeforest
reviewed
Aug 27, 2019
apeforest
reviewed
Aug 27, 2019
…ed random tuples in test_operator.py for nearest neighbor upsampling test cases, changed scaleComp in upsampling-inl.h back to returning vector
Ping @huangzhiyuan for review. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the option to specify different scales for different dimensions.
Ref: #12602
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments