Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

FullyConnected Bias performance improvement on GPU #16039

Merged
merged 8 commits into from
Sep 24, 2019

Conversation

ptrendx
Copy link
Member

@ptrendx ptrendx commented Aug 29, 2019

Description

This PR improves performance of bias addition kernel (both fwd and bwd) in FullyConnected operator.

@eric-haibin-lin FYI

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@karan6181
Copy link
Contributor

@mxnet-label-bot add [Cuda, Operator, pr-awaiting-review]

@marcoabreu marcoabreu added CUDA Operator pr-awaiting-review PR is waiting for code review labels Aug 30, 2019
src/common/cuda_utils.h Show resolved Hide resolved
src/operator/mxnet_op.h Show resolved Hide resolved
src/operator/nn/fully_connected-inl.h Show resolved Hide resolved
src/operator/nn/fully_connected-inl.h Show resolved Hide resolved
Copy link
Contributor

@DickJC123 DickJC123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@DickJC123 DickJC123 merged commit a5e698a into apache:master Sep 24, 2019
drivanov pushed a commit to drivanov/incubator-mxnet that referenced this pull request Sep 26, 2019
* FullyConnected Bias performance improvement on GPU

* Handle req properly

* Fix after rebase

* More fixes from rebase

* Fix lint

* Trigger CI

* Fixes from review

* Fix
larroy pushed a commit to larroy/mxnet that referenced this pull request Sep 28, 2019
* FullyConnected Bias performance improvement on GPU

* Handle req properly

* Fix after rebase

* More fixes from rebase

* Fix lint

* Trigger CI

* Fixes from review

* Fix
eric-haibin-lin added a commit to eric-haibin-lin/mxnet that referenced this pull request Dec 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CUDA Operator pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants