This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
FullyConnected Bias performance improvement on GPU #16039
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mxnet-label-bot add [Cuda, Operator, pr-awaiting-review] |
DickJC123
reviewed
Sep 17, 2019
DickJC123
reviewed
Sep 24, 2019
DickJC123
approved these changes
Sep 24, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
drivanov
pushed a commit
to drivanov/incubator-mxnet
that referenced
this pull request
Sep 26, 2019
* FullyConnected Bias performance improvement on GPU * Handle req properly * Fix after rebase * More fixes from rebase * Fix lint * Trigger CI * Fixes from review * Fix
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
Sep 28, 2019
* FullyConnected Bias performance improvement on GPU * Handle req properly * Fix after rebase * More fixes from rebase * Fix lint * Trigger CI * Fixes from review * Fix
eric-haibin-lin
added a commit
to eric-haibin-lin/mxnet
that referenced
this pull request
Dec 14, 2019
)" This reverts commit a5e698a.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves performance of bias addition kernel (both fwd and bwd) in FullyConnected operator.
@eric-haibin-lin FYI
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.