This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Tutorials nighly fix #16179
Merged
Tutorials nighly fix #16179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github issue created - #16181 for reenabling tests once we have fixes. |
anirudh2290
reviewed
Sep 16, 2019
anirudh2290
approved these changes
Sep 16, 2019
| @@ -31,7 +31,7 @@ | |||
|
|
|||
|
|
|||
| IPYTHON_VERSION = 4 # Pin to ipython version 4. | |||
| TIME_OUT = 10*60 # Maximum 10 mins/test. Reaching timeout causes test failure. | |||
| TIME_OUT = 15*60 # Maximum 10 mins/test. Reaching timeout causes test failure. | |||
There was a problem hiding this comment.
nit: can you update the comment to max 15 mins/ test
There was a problem hiding this comment.
i am going to merge this PR to unblock nightlies. @access2rohit since this change is small, would you be able to add this change to one of your WIP PRs?
|
one nitpicky comment rest LGTM! |
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
Sep 28, 2019
* Fixing tutorials test failures * profier set state * modifying Jenkins for fast run * chanign comments * more test comment for faster run * changing comments from * more comments * profiler tutorial test fixes * uncommenting all tutorial tests * enabling all tests for nightly * removing parallel keyword from tutorials test * updating comments * Added github issue link in the comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing tutorials test.
Disabling some tutorials test until we get a fix for them. Explicitly disabling gluon perf test, profiler test and mkldnn tutorial test
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments