Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

remove unused file with license issue #17371

Merged
merged 1 commit into from
Jan 18, 2020
Merged

remove unused file with license issue #17371

merged 1 commit into from
Jan 18, 2020

Conversation

roywei
Copy link
Member

@roywei roywei commented Jan 18, 2020

Description

Fix part of #17329
/sh2ju.sh has a license issue and is only used by test_all.sh
But both these scripts seems very old and not used anywhere in the project, so I'm removing these files to avoid further confusion.

@apeforest You are the last one who modified these files in #11742
Could you confirm whether you still need it?
Thanks

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@roywei roywei requested a review from apeforest January 18, 2020 07:02
@roywei roywei merged commit 6505f53 into apache:master Jan 18, 2020
szhengac pushed a commit to szhengac/mxnet that referenced this pull request Jan 21, 2020
refactor optimizer
bf721af 
refactor_optimizer

update sgd lars

refactor updater

fix test

hybridize optimizer

refactor optimizer python interface

fix order of weight decay and grad clip

fix position epsilon in optimizer

add tests

refactor optimizer

refactor_optimizer

update sgd lars

refactor updater

hybridize optimizer

refactor optimizer python interface

fix order of weight decay and grad clip

fix position epsilon in optimizer

add tests

fix const

fix ;

fix

fic

fix

fix

fix

fix

fix signum test

fix

fix nag kernel

fix nag kernel

fix nag kernel

fix nag kernel

fix ftrl kernel

fix ftrl kernel

fix ftrl kernel

fix ftrl kernel

fix ftrl kernel

fix ftrl kernel

fix ftrl kernel

fix test

fix test

update

update

fix lamb

add assertion to lamb

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

update

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix lamb test

fix

fix

fix

fix

fix

fix

remove unused file with license issue (apache#17371)

fix

fix

fix

fix

fix

fix

fix

fix

fix flaky test
szhengac pushed a commit to szhengac/mxnet that referenced this pull request Jan 21, 2020
@roywei
remove unused file with license issue (apache#17371)
d6aa6be
szhengac pushed a commit to szhengac/mxnet that referenced this pull request Jan 21, 2020
@roywei
remove unused file with license issue (apache#17371)
c2b4a8e
szhengac pushed a commit to szhengac/mxnet that referenced this pull request Jan 21, 2020
@roywei
remove unused file with license issue (apache#17371)
32f4110
roywei added a commit to roywei/incubator-mxnet that referenced this pull request Jan 28, 2020
@roywei
remove unused file with license issue (apache#17371)
a463c82
@roywei roywei mentioned this pull request Jan 28, 2020
Merged
szha pushed a commit that referenced this pull request Jan 29, 2020
@roywei @eric-haibin-lin
Cherry pick license fixes for 1.6 (#17460)
6eec9da 
* Update NOTICE to fix copyright years (#17330)

* Update LICENSE for fonts (#17365)

* license np_einsum file under bsd (#17367)

* license under bsd

* fix rat exclude

* remove unused file with license issue (#17371)

* [LICENSE] fix cpp predcit license (#17377)

* fix cpp predcit license

* add white list (#210)

* fix white list (#211)

Co-authored-by: Lai Wei <royweilai@gmail.com>

* add disclaimer (#17428)

* add disclaimer

* add white list

* fix exclude

* remove disclaimer

* update tools/pip

Co-authored-by: Haibin Lin <linhaibin.eric@gmail.com>
@roywei roywei deleted the license_fix branch January 29, 2020 19:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@apeforest apeforest apeforest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roywei @apeforest