Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

remove -mf16c flag for andriod build(Tiny change) #17523

Merged
merged 2 commits into from
Feb 27, 2020
Merged

remove -mf16c flag for andriod build(Tiny change) #17523

merged 2 commits into from
Feb 27, 2020

Conversation

michiboo
Copy link
Contributor

@michiboo michiboo commented Feb 5, 2020

Description

Removed unused -mf16c compiler flag in android build as describe in #15935

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • [x ] Changes are complete (i.e. I finished coding on this PR)
  • [x ] All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • [ x] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@michiboo michiboo requested a review from szha as a code owner February 5, 2020 07:22
@michiboo michiboo changed the title remove -mf15c flag for andriod build remove -mf15c flag for andriod build(Tiny change) Feb 5, 2020
@TaoLv
Copy link
Member

TaoLv commented Feb 5, 2020

Could you please fix the title? It should be -mf16c.

@TaoLv TaoLv added the CMake CMake related bugs/issues/improvements label Feb 5, 2020
@leezu leezu changed the title remove -mf15c flag for andriod build(Tiny change) remove -mf16c flag for andriod build(Tiny change) Feb 5, 2020
@leezu leezu merged commit 55e6987 into apache:master Feb 27, 2020
MoisesHer pushed a commit to MoisesHer/incubator-mxnet that referenced this pull request Apr 10, 2020
Co-authored-by: Leonard Lausen <leonard@lausen.nl>
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request May 29, 2020
Co-authored-by: Leonard Lausen <leonard@lausen.nl>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CMake CMake related bugs/issues/improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants