Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[WIP] passing ndarrays to acceptSubgraph API #17564

Closed
wants to merge 1 commit into from

Conversation

samskalicky
Copy link
Contributor

Description

adding support for compilation of subgraphs by passing ndarrays to acceptSubgraph API. This will support compiling subgraphs for TensorRT or TVM backends.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

Copy link
Member

@szha szha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for proposing the change. I'm looking for more description to help understand the purpose of this API change. Also, make sure to add the tests.

@samskalicky
Copy link
Contributor Author

There seems to be too much confusion around this PR, i'll reopen it again when I get a chance to do more work on it

@samskalicky samskalicky deleted the compile branch February 11, 2020 22:10
@samskalicky
Copy link
Contributor Author

reopened here: #17623

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants