This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Fix get_started pip instructions #17725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The class attribute in the respective .md files must match one of the versions listed in the version dropdown specified in get_started.html
ChaiBapchya
reviewed
Feb 29, 2020
| @@ -70,4 +70,4 @@ $ pip install --pre mxnet -f https://dist.mxnet.io/python/all | |||
| </div> <!-- End of master--> | |||
|
|
|||
| {% include /get_started/pip_snippet.md %} | |||
| {% include /get_started/gpu_snippet.md %} | |||
There was a problem hiding this comment.
what has changed in all these gpu_snippets?
There was a problem hiding this comment.
I bet it is eol character - those md files had no eol before
There was a problem hiding this comment.
Yes. My editor ensures each file has eol by default
MoisesHer
pushed a commit
to MoisesHer/incubator-mxnet
that referenced
this pull request
Apr 10, 2020
The class attribute in the respective .md files should match one of the versions listed in the version dropdown specified in get_started.html
anirudh2290
pushed a commit
to anirudh2290/mxnet
that referenced
this pull request
May 29, 2020
The class attribute in the respective .md files should match one of the versions listed in the version dropdown specified in get_started.html
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class attribute in the respective .md files must match one of the versions
listed in the version dropdown specified in get_started.html
Without this fix, the instructions for installing version 1.5 will always be shown, even if users select another version in the dropdown.
CC @TaoLv, as this error was introduced in #16442.