-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[v1.7.x] Backport fixing batch_norm and layer_norm for large tensors (#17805) #18261
Conversation
Co-authored-by: Rohit Kumar Srivastava <srivastava.141@buckeyemail.osu.edu>
Hey @ChaiBapchya , Thanks for submitting the PR
CI supported jobs: [miscellaneous, centos-cpu, sanity, centos-gpu, website, windows-gpu, unix-cpu, clang, unix-gpu, edge, windows-cpu] Note: |
Fixes #18246 |
Seems it failed to fetch the external packages for TVM, please re-trigger the CI. |
@mxnet-bot run ci [unix-cpu, unix-gpu, clang] |
Jenkins CI successfully triggered : [unix-cpu, clang, unix-gpu] |
@mxnet-bot run ci [unix-cpu, unix-gpu] |
Jenkins CI successfully triggered : [unix-cpu, unix-gpu] |
Still fail to fetch clang_llvm package, please help to trigger again, thanks! :) |
@mxnet-bot run ci [unix-cpu,unix-gpu] |
Jenkins CI successfully triggered : [unix-cpu, unix-gpu] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Since this is merged, I have retriggered the NightlyTestForBinaries for v1.7.x branch Hopefully it passes |
Hi @ChaiBapchya thanks a lot for your prompt fix :) BTW, does it need to manually trigger the tests (both NightlyTest and NightlyTestForBinaries) when needed or they'll be triggered automatically once there's any new commit? |
@ChaiBapchya unfortunately, the failure still happened in the nightly test, please check log here. Something different in local and jenkins server? |
Sorry for that confusion. As you can see here : http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/NightlyTestsForBinaries/detail/v1.7.x/3/pipeline By mistake, instead of triggering a build using "Build Now" tab in Jenkins here : http://jenkins.mxnet-ci.amazon-ml.com/job/NightlyTestsForBinaries/job/v1.7.x/ I replayed # 2 [thinking it will have the same effect]. But no, it doesn't pick up new commits as you can see in build # 3 [it says no changes]. Now I triggered the build correctly, build # 4 [http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/NightlyTestsForBinaries/detail/v1.7.x/4/pipeline] |
No it hasn't been configured to be triggered for every commit because it is "Nightly". But I will check why it isn't being triggered on a Nightly basis either. Checking the configure tab of the pipeline doesn't reveal any triggering mechanism is in place on Jenkins side. Maybe it's done in some other way. Let me get back. |
Hi @ChaiBapchya , thanks a lot for your great support to fix #18246! NightlyTestForBinaries passed now:) Let's wait for a while to see if NightlyTest pipeline works. |
Hi @ChaiBapchya , I'm wondering if you got a chance to check the trigger issue for nightly test (both NightlyTests and NightlyTestsForBinaries)? Seems they're failed to be triggered "nightly". |
@ChaiBapchya , can you help to trigger both of NightTests an NightlyTestsForBinaries for v1.7.x branch, as there're several PRs get merged recently. |
Triggered NightlyTests and NightlyTestsForBinaries for v1.7.x |
Hi @ChaiBapchya , appreciate for your kindly help, I will give a try in the following day to trigger the nightly build. Will let you know if it works :) |
This PR was miss in v1.x branch, need to backport to v1.x and v1.8.x. @samskalicky @ChaiBapchya |
Backport #17805 to fix large tensor nightly test issue
Co-authored-by: Rohit Kumar Srivastava srivastava.141@buckeyemail.osu.edu
Verified the changes locally by
setting up the Infra https://cwiki.apache.org/confluence/display/MXNET/Reproducing+test+results
Build :
Test