-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
Hey @hanke580 , Thanks for submitting the PR
CI supported jobs: [unix-cpu, centos-gpu, clang, centos-cpu, edge, miscellaneous, sanity, website, windows-cpu, unix-gpu, windows-gpu] Note: |
@hanke580 Would you fix the lint check and add some test cases? |
Sure, tests adding |
4dd7cf4
to
3802104
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This looks like something we should backport to 1.6, 1.7, 1.x branches @hanke580 @sxjscience? cc @ciyongch |
It should be backported to 1.7. |
Hi @hanke580 , can you help to backport this PR to v1.7.x branch as suggested by @sxjscience and @leezu , and tag me in the new PR? Thanks. |
Sure @ciyongch |
* * Fix einsum Bug * * Fix sanity * * Fix one dim start bug * * Fix test case gt
* * Fix einsum Bug * * Fix sanity * * Fix one dim start bug * * Fix test case gt
@sxjscience Why isn't this backported to v1.x branch? Any specific reason or just a miss? |
It's just a miss. |
Can we get a cherry-pick for this? |
Description
Fix einsum gradient bug in Issue #18102
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments