Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] backport #18500 - [Bug Fixed] Fix batch norm when grad_req is add #18518

Merged
merged 4 commits into from
Jun 9, 2020

Conversation

wkcn
Copy link
Member

@wkcn wkcn commented Jun 8, 2020

Description

Bacport #18500
I only change the unit-test to make it compatible with the eldder version of MXNet.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

Hey @wkcn , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-cpu, clang, centos-gpu, windows-gpu, miscellaneous, edge, sanity, unix-gpu, unix-cpu, website, centos-cpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@wkcn wkcn added the Backport 1.x Pending backport to 1.x label Jun 9, 2020
@ciyongch
Copy link
Contributor

ciyongch commented Jun 9, 2020

Hi @TaoLv , @pengzhao-intel please help to review and merged. This PR fixed the functionality issue for BN gradient. The corresponding one for master was merged #18500.

@szha szha merged commit 798a264 into apache:v1.x Jun 9, 2020
ChaiBapchya pushed a commit to ChaiBapchya/mxnet that referenced this pull request Jul 15, 2020
…eq is `add` (apache#18518)

* Fix batch norm when grad_req is

* fix

* remove softmax test

* fix
leezu pushed a commit that referenced this pull request Jul 23, 2020
…18714)

* [Bug Fixed] Fix batch norm when grad_req is `add` (#18500)

* fix batch norm when fix_gamma is True

* support gradient accumulation for batch norm

* mkldnn batchnorm support grad add

* unittest for bn

* fix bn arg

* fix lint

* fix mkldnn

* fix mkldnn bn

* fix grad when fixing gamma

* fix naive gpu bn

* fix lint

* fix cudnn bn

* fix flag

* fix lint

* fix testcase

* fix

* use @pytest.mark.parametrize

* combination

* remove redundant test in batchnorm

* npx.batch_norm test

* try to fix test

* reduce the number of tests for batchnorm

* fix

* Revert "[Bug Fixed] Fix batch norm when grad_req is `add` (#18500)"

This reverts commit 8e32cd6.

* [v1.x] backport #18500 - [Bug Fixed] Fix batch norm when grad_req is `add` (#18518)

* Fix batch norm when grad_req is

* fix

* remove softmax test

* fix

* add copy_size

* Fix init method for TestBatchNorm

Co-authored-by: JackieWu <wkcn@live.cn>
ChaiBapchya pushed a commit to ChaiBapchya/mxnet that referenced this pull request Aug 15, 2020
…eq is `add` (apache#18518)

* Fix batch norm when grad_req is

* fix

* remove softmax test

* fix
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Backport 1.x Pending backport to 1.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants