This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Fix CentOS CI builds: Only create symlink when target doesn't exist. #18908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @josephevans , Thanks for submitting the PR
CI supported jobs: [miscellaneous, unix-cpu, clang, centos-gpu, windows-gpu, website, edge, centos-cpu, windows-cpu, unix-gpu, sanity] Note: |
|
@josephevans seems like a duplicate of #18906 from @leezu ? thanks to both of you for fixing it |
Yep, I'll close this. Thanks for the heads up! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command for creating a symlink from /usr/bin/ninja-build to /usr/bin/ninja is failing, because it already exists. It looks like CentOS may have changed their packages to create this file/symlink. This PR only attempts to create it if it doesn't already exists.