Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] backport remove upper bound (#18857) #18910

Merged
merged 1 commit into from
Aug 19, 2020

Conversation

wkcn
Copy link
Member

@wkcn wkcn commented Aug 12, 2020

Description

Backport #18857

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@wkcn wkcn added Backport 1.x Pending backport to 1.x v1.x Targeting v1.x branch labels Aug 12, 2020
@mxnet-bot
Copy link

Hey @wkcn , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-cpu, sanity, unix-gpu, website, centos-gpu, windows-cpu, windows-gpu, miscellaneous, clang, unix-cpu, edge]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@wkcn wkcn changed the title [v1.x] remove upper bound (#18857) [v1.x] backport remove upper bound (#18857) Aug 12, 2020
@wkcn wkcn mentioned this pull request Aug 12, 2020
@wkcn
Copy link
Member Author

wkcn commented Aug 12, 2020

CI Error
https://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-cpu/detail/PR-18910/1/pipeline

[2020-08-12T04:00:34.354Z] + wget https://mirror.clarkson.edu/gnu/binutils/binutils-2.27.tar.gz

[2020-08-12T04:00:34.354Z] --2020-08-12 04:00:34--  https://mirror.clarkson.edu/gnu/binutils/binutils-2.27.tar.gz

[2020-08-12T04:00:34.354Z] Resolving mirror.clarkson.edu (mirror.clarkson.edu)... 128.153.145.19, 2605:6480:c051:100::1

[2020-08-12T04:00:34.354Z] Connecting to mirror.clarkson.edu (mirror.clarkson.edu)|128.153.145.19|:443... connected.

[2020-08-12T04:00:34.608Z] HTTP request sent, awaiting response... 403 Forbidden

[2020-08-12T04:00:34.608Z] 2020-08-12 04:00:34 ERROR 403: Forbidden.

@wkcn
Copy link
Member Author

wkcn commented Aug 12, 2020

@mxnet-bot run ci [unix-cpu, unix-gpu, windows-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu, unix-cpu, windows-cpu]

@wkcn
Copy link
Member Author

wkcn commented Aug 14, 2020

@mxnet-bot run ci [unix-cpu, unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu, unix-gpu]

@samskalicky
Copy link
Contributor

@wkcn can you rebase? There were a few fixes that went into the v1.x branch in the past few days that may fix the two CI failures

@wkcn
Copy link
Member Author

wkcn commented Aug 19, 2020

@mxnet-bot run ci [unix-cpu, unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu, unix-gpu]

@szha szha merged commit b4da2dd into apache:v1.x Aug 19, 2020
@szha szha added this to the v1.8.0 milestone Aug 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Backport 1.x Pending backport to 1.x v1.x Targeting v1.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants