Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[EXAMPLE] Fix MNIST classification example #19072

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Conversation

r3stl355
Copy link
Contributor

@r3stl355 r3stl355 commented Sep 2, 2020

Description

An attempt to run example/gluon/mnist/mnist.py throwing error AttributeError: 'Sequential' object has no attribute 'name_scope'. Removing with net.name_scope(): fixed the problem. Script now runs and completes the training.

Checklist

Essentials

  • [X ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • [X ] Changes are complete (i.e. I finished coding on this PR)
  • [- ] All changes have test coverage - there are no tests but example script runs after this fix
  • [X ] Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

Hey @r3stl355 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-cpu, centos-gpu, windows-gpu, website, windows-cpu, clang, edge, unix-gpu, sanity, miscellaneous, unix-cpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@r3stl355
Copy link
Contributor Author

r3stl355 commented Sep 2, 2020

Looks like I did something here but can't understand what, any help please? My first PR

@leezu
Copy link
Contributor

leezu commented Sep 2, 2020

Thank you @r3stl355. The name_scope was removed in the master branch for MXNet 2, but the example wasn't updated.

@leezu leezu merged commit 4cfb9e1 into apache:master Sep 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants