Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

avoid skipping validation stage when data read iterator exists #18289 #19096

Merged
merged 1 commit into from
Sep 7, 2020

Conversation

szha
Copy link
Member

@szha szha commented Sep 7, 2020

Description

#18289 for v1.x

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

Hey @szha , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-cpu, centos-cpu, centos-gpu, clang, windows-gpu, edge, windows-cpu, unix-gpu, website, sanity, miscellaneous]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@szha
Copy link
Member Author

szha commented Sep 7, 2020

I reviewed this PR in #18289. Thanks to @heaseny for the original contribution.

@szha szha merged commit 8dbed96 into v1.x Sep 7, 2020
@szha szha deleted the szha-patch-1 branch September 7, 2020 20:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants