-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Improve createOpState for custom ops #19103
Conversation
Hey @samskalicky , Thanks for submitting the PR
CI supported jobs: [unix-gpu, miscellaneous, edge, sanity, windows-gpu, unix-cpu, centos-gpu, clang, centos-cpu, windows-cpu, website] Note: |
@mseth10 @rondogency this is a small PR with just the change for custom stateful ops. Please review, thanks! |
thanks for the enhancement! as we are approaching the (beta) release of mxnet, do you think the API would be finalized with this PR? |
I think so, with this PR the examples are all up to date now with Gluon (having removed the symbol bind/executor stuff). As with anything, as it gets more use we'll find ways to improve things. But we're ready to start helping users extend MXNet! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank You for you contribution!
One quick request, in terms of the test, can you add an end-to-end test training example written in gluon like this one: #18167, so that we can have better test suite on performance to show to user |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! the above comment can be addressed in the future PR
Description
Support passing all args from createOpState to custom ops: context, input shapes & types
Checklist
Essentials
Changes
Comments