This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[v1.x] Backport Improve environment variable handling in unittests (#18424) #19173
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a backport to v1.x of the PR #18424. The original PR built on the work of @larroy, and introduced the
with environment():
context and@with_environment()
decorator. The PR replaced the ad hoc manipulation of environment variables in unittests and solved the 'read-only env var state' problem of Windows.Checklist
Essentials