-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
Hey @Neutron3529 , Thanks for submitting the PR
CI supported jobs: [centos-gpu, unix-cpu, website, unix-gpu, miscellaneous, windows-gpu, sanity, centos-cpu, edge, clang, windows-cpu] Note: |
@mxnet-bot run ci [centos-gpu, unix-cpu, unix-gpu] |
Jenkins CI successfully triggered : [unix-cpu, centos-gpu, unix-gpu] |
@mxnet-bot run ci [centos-cpu] |
Jenkins CI successfully triggered : [centos-cpu] |
@mxnet-bot run ci [centos-gpu,unix-cpu] seems something wrong with the network connection. |
Jenkins CI successfully triggered : [centos-gpu, unix-cpu] |
@mxnet-bot run ci [centos-cpu,unix-cpu,unix-gpu] |
Jenkins CI successfully triggered : [unix-cpu, centos-cpu, unix-gpu] |
errors of unix-gpu:
errors in unix-cpu
errors in centos-cpu
what I could do? |
Undefined action detected. |
@mxnet-bot run ci [unix-cpu, centos-cpu, unix-gpu] |
@mxnet-bot run ci [unix-cpu, unix-gpu] |
Jenkins CI successfully triggered : [unix-gpu, unix-cpu] |
@mxnet-bot run ci [unix-cpu, unix-gpu] |
Jenkins CI successfully triggered : [unix-cpu, unix-gpu] |
@mxnet-bot run ci [unix-cpu, unix-gpu] |
Jenkins CI successfully triggered : [unix-cpu, unix-gpu] |
@mxnet-bot run ci [unix-cpu, unix-gpu] |
Jenkins CI successfully triggered : [unix-gpu, unix-cpu] |
@Neutron3529 thanks for backporting and sorry that it took several tries to get it through the CI. Fortunately, thanks to @josephevans the CI is now stabilized. |
Description
In the current version of KLDivLoss, the return value is not the same value calculated by SoftmaxCrossEntropyLoss, which is not documented. It may due to the incorrect settings which using mean rather than sum dealing with the return value.
I provide a fix of this setting, which will keep the return value of
KLDivLoss
andSoftmaxCrossEntropyLoss
almost the same whenfrom_logits=False
andsparse_label=False
are set to these functions seperately.Now, the behave of KLDivLoss is exactly the same to what the document say.
to reproduce the misbehave in the current master branch:
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments