Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[1.x] Add test case for oneDNN RNN #19464

Merged
merged 1 commit into from
Nov 6, 2020
Merged

[1.x] Add test case for oneDNN RNN #19464

merged 1 commit into from
Nov 6, 2020

Conversation

bgawrych
Copy link
Contributor

@bgawrych bgawrych commented Nov 2, 2020 •
edited
Loading

Description

This PR enables test case which produces seg faults with oneDNN < 1.6.5
#19308
#19451

Problem should be fixed with: #19449

@mxnet-bot
Copy link

Hey @bgawrych , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-cpu, unix-gpu, windows-cpu, windows-gpu, website, clang, sanity, centos-gpu, miscellaneous, unix-cpu, edge]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 2, 2020
@bgawrych
Copy link
Contributor Author

bgawrych commented Nov 3, 2020

@mxnet-bot run ci [centos-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-cpu]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 3, 2020
@samskalicky
Copy link
Contributor

Hi @bgawrych, the centos-cpu failure can be fixed by 655d81f

You can either pull it in yourself, or wait until after my PR adds this #19456

@samskalicky
Copy link
Contributor

Hi @bgawrych, the centos-cpu failure can be fixed by 655d81f

You can either pull it in yourself, or wait until after my PR adds this #19456

should be fixed now from #19476 can you rebase/merge?

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Nov 6, 2020
pengzhao-intel
pengzhao-intel approved these changes Nov 6, 2020
View reviewed changes
Copy link
Contributor

@pengzhao-intel pengzhao-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and will merge after CI pass.

@lanking520 lanking520 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 6, 2020
@bgawrych
Copy link
Contributor Author

bgawrych commented Nov 6, 2020

@szha @samskalicky @pengzhao-intel This codecov/project job must be passed to merge?

@szha szha merged commit b30b9c1 into apache:v1.x Nov 6, 2020
josephevans pushed a commit to josephevans/mxnet that referenced this pull request Dec 8, 2020
@bgawrych
Add test case for oneDNN RNN (apache#19464)
ddd491d
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pengzhao-intel pengzhao-intel pengzhao-intel approved these changes

Assignees
No one assigned
Labels
MKLDNN pr-work-in-progress PR is still work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bgawrych @mxnet-bot @samskalicky @pengzhao-intel @szha @lanking520