Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] Change gcc 8 PPA to ppa:jonathonf/gcc #19638

Merged
merged 1 commit into from
Dec 8, 2020
Merged

[v1.x] Change gcc 8 PPA to ppa:jonathonf/gcc #19638

merged 1 commit into from
Dec 8, 2020

Conversation

kpuatamazon
Copy link
Contributor

Description

Attempt to fix broken CI for v1.x #19636.
https://jenkins.mxnet-ci.amazon-ml.com/blue/rest/organizations/jenkins/pipelines/mxnet-validation/pipelines/sanity/branches/PR-19601/runs/7/nodes/39/steps/80/log/?start=0

CI broke because the PPA changed from versioned gcc to one bucket for all the gcc versions: https://launchpad.net/~jonathonf/+archive/ubuntu/gcc

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage

@mxnet-bot
Copy link

Hey @kpuatamazon , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [clang, edge, centos-cpu, sanity, website, windows-cpu, windows-gpu, centos-gpu, unix-cpu, unix-gpu, miscellaneous]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 7, 2020
@kpuatamazon
Copy link
Contributor Author

When random perl tests fail, try again @mxnet-bot run ci [unix-gpu]

[2020-12-07T16:11:49.792Z] 
[2020-12-07T16:11:49.792Z] #   Failed test at t/test_module.t line 593.
[2020-12-07T16:11:49.792Z] # Looks like you failed 1 test of 428.
[2020-12-07T16:11:49.792Z] t/test_module.t .............

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Dec 7, 2020
@kpuatamazon kpuatamazon mentioned this pull request Dec 7, 2020
Merged
6 tasks
@lanking520 lanking520 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 7, 2020
@kpuatamazon
Copy link
Contributor Author

@mxnet-bot run ci [unix-gpu-cu110]
Timed out: https://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/mxnet-validation%2Funix-gpu-cu110/detail/PR-19638/1/pipeline/77/

@mxnet-bot
Copy link

None of the jobs entered are supported.
Jobs entered by user: [unix-gpu-cu110]
CI supported Jobs: [clang, website, miscellaneous, windows-cpu, sanity, centos-gpu, windows-gpu, edge, centos-cpu, unix-cpu, unix-gpu]

@kpuatamazon
Copy link
Contributor Author

I think this is ready. The new non-required unix-gpu-cu110 job timed out while it was still running tests and can't be rerun by the bot. Also changing how gcc 8 is installed is unlikely to be the cause.

@aaronmarkham @marcoabreu

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 8, 2020
@josephevans
Copy link
Contributor

josephevans commented Dec 8, 2020 •
edited
Loading

Looks good, LGTM! Thanks for the CI fix!

@Zha0q1 Zha0q1 merged commit bbfccae into apache:v1.x Dec 8, 2020
josephevans pushed a commit to josephevans/mxnet that referenced this pull request Dec 11, 2020
@kpuatamazon
Change gcc 8 PPA to ppa:jonathonf/gcc (apache#19638)
abfc34a
@josephevans josephevans mentioned this pull request Dec 11, 2020
Merged
mseth10 pushed a commit that referenced this pull request Dec 11, 2020
@josephevans @rondogency @kpuatamazon
[v1.8.x] Backport #19656 - fix R builds (#19658)
d94e47c 
* Attempt to fix R builds.

* Remove obsolete six dependency (#19620)

* Change gcc 8 PPA to ppa:jonathonf/gcc (#19638)

Co-authored-by: Joe Evans <joeev@amazon.com>
Co-authored-by: Ziyi Mu <ziyi.mu@columbia.edu>
Co-authored-by: kpuatamazon <56725192+kpuatamazon@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephevans josephevans josephevans approved these changes

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@marcoabreu marcoabreu Awaiting requested review from marcoabreu marcoabreu is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kpuatamazon @mxnet-bot @josephevans @lanking520 @Zha0q1