Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[LICENSE] Reorganize rat-excludes file to ease license auditing #19743

Merged
merged 2 commits into from
Jan 15, 2021
Merged

[LICENSE] Reorganize rat-excludes file to ease license auditing #19743

merged 2 commits into from
Jan 15, 2021

Conversation

szha
Copy link
Member

@szha szha commented Jan 12, 2021

Description

Reorganize rat-excludes file to ease license auditing

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Reorganize rat-excludes file to ease license auditing

@szha szha requested a review from leezu January 12, 2021 18:21
@mxnet-bot
Copy link

Hey @szha , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-cpu, unix-cpu, miscellaneous, centos-gpu, sanity, website, unix-gpu, edge, centos-cpu, windows-gpu, clang]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@szha
Copy link
Member Author

szha commented Jan 12, 2021 •
edited
Loading

cc @samskalicky @TristonC @sandeep-krishnamurthy

@lanking520 lanking520 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Jan 12, 2021
@lanking520 lanking520 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Jan 12, 2021
samskalicky
samskalicky reviewed Jan 13, 2021
View reviewed changes
Copy link
Contributor

@samskalicky samskalicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANKS! (thats a big thanks ;-D)

Any particular reason to move the file to tools/apache_rat_license_check/rat-excludes instead of just putting it at the top level of the repo?

@szha
Copy link
Member Author

szha commented Jan 13, 2021

Any particular reason to move the file to tools/apache_rat_license_check/rat-excludes instead of just putting it at the top level of the repo?

I kept the folder so that the apache_rat_license_check/README.md can be together with the allowlist file. Looking at the readme, I think it's ok to remove this file and incorporate some of the information into the allowlist as comments. I will go ahead and make the change.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 13, 2021
samskalicky
samskalicky approved these changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@samskalicky samskalicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @szha !

@szha
Copy link
Member Author

szha commented Jan 15, 2021

I think the PR remained open long enough for feedback. I will merge it for now and I'm happy to update if there's any follow-up comment.

@szha szha merged commit 19ede06 into apache:master Jan 15, 2021
@szha szha deleted the rat_list branch January 15, 2021 22:49
szha added a commit to szha/mxnet that referenced this pull request Jan 28, 2021
@szha
[LICENSE] Reorganize rat-excludes file to ease license auditing (apac…
206a0a8 
…he#19743)

* Reorganize rat-excludes file to ease license auditing

* move rat-excludes to top level
@szha szha mentioned this pull request Jan 28, 2021
Merged
szha added a commit to szha/mxnet that referenced this pull request Feb 8, 2021
@szha
[LICENSE] Reorganize rat-excludes file to ease license auditing (apac…
0dd2fab 
…he#19743)

* Reorganize rat-excludes file to ease license auditing

* move rat-excludes to top level
samskalicky pushed a commit that referenced this pull request Feb 15, 2021
@szha
[v1.x] Backport [LICENSE] Reorganize rat-excludes file to ease licens…
58e7d0e 
…e auditing (#19743) (#19799)

* [LICENSE] Reorganize rat-excludes file to ease license auditing (#19743)

* Reorganize rat-excludes file to ease license auditing

* move rat-excludes to top level

* CI:fix test_rat_check

Signed-off-by: Sheng Zha <zhasheng@amazon.com>

* fix license issues in 1.x

Signed-off-by: Sheng Zha <zhasheng@amazon.com>

* fix rat jar name

Signed-off-by: Sheng Zha <zhasheng@amazon.com>
@waytrue17 waytrue17 mentioned this pull request Feb 17, 2021
Merged
6 tasks
@mseth10 mseth10 mentioned this pull request Feb 19, 2021
Open
@waytrue17 waytrue17 mentioned this pull request Feb 23, 2021
Merged
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leezu leezu leezu left review comments

@samskalicky samskalicky samskalicky approved these changes

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@marcoabreu marcoabreu Awaiting requested review from marcoabreu marcoabreu is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@szha @mxnet-bot @leezu @samskalicky @lanking520