Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Adding MxNet.Sharp package to the ecosystem page #20162

Merged
merged 8 commits into from
May 15, 2021

Conversation

deepakkumar1984
Copy link
Contributor

As discussed here: #16167 (comment)

I have added one more package to the list of the ecosystem.

Changes

  1. Add new image for MxNet.Sharp to the asset/img folder
  2. Update the ecosystem.html to add project details

@mxnet-bot
Copy link

Hey @deepakkumar1984 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [clang, unix-cpu, windows-cpu, centos-cpu, miscellaneous, centos-gpu, sanity, edge, unix-gpu, windows-gpu, website]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Apr 13, 2021
@lanking520 lanking520 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Apr 14, 2021
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Apr 14, 2021
@szha
Copy link
Member

szha commented Apr 16, 2021

@deepakkumar1984 thanks for the contribution. Looks like you included the c# package itself in this PR. Since that's a large change and has implication to the commitment of this community, it would be better to have a request-for-comment (RFC) for adding the c# support.

With the RFC, we want to make sure the new language binding and examples will be well maintained in this code base. Information such as the current maintainers of the package, the necessary CI support, license information, intended release cycle and distribution channels, and expected user groups, are all relevant. Once these factors are clarified, the assimilation of the code base can be done as a one-time donation via software grant (see https://www.apache.org/foundation/how-it-works/legal.html#incoming-code), with which we could include you or intended maintainers as committers once the community agrees. In addition, note that mxnet is a trademark of the Apache Software Foundation which has specific naming requirements. The guideline is here: https://www.apache.org/foundation/marks/faq/#products.

I know it's a lot to take in and adding a language binding is a big step. I will offer help wherever I can and feel free to let me know if you have questions. In this PR, shall we focus on adding the reference to the package in the ecosystem page first?

@deepakkumar1984
Copy link
Contributor Author

Thanks @szha for the detailed info, I have removed the csharp-package and only the ecosystem page changes is there in this PR. I can start another RFC thread for adding the c# package and continue with further discussions. Indeed its a big step and your guidance will be needed and hopefully will be able to merge it smootly.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels May 6, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels May 14, 2021
@mseth10 mseth10 added pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels May 14, 2021
@szha szha merged commit c9301af into apache:master May 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants