This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[v1.x] Enabling BRGEMM FullyConnected based on shapes #20533
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @bgawrych , Thanks for submitting the PR
CI supported jobs: [miscellaneous, sanity, centos-cpu, unix-gpu, clang, edge, centos-gpu, windows-cpu, website, windows-gpu, unix-cpu] Note: |
mseth10
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
and removed
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Aug 17, 2021
mseth10
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-awaiting-review
PR is waiting for code review
and removed
pr-work-in-progress
PR is still work in progress
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Aug 18, 2021
anko-intel
reviewed
Aug 18, 2021
mseth10
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-awaiting-review
PR is waiting for code review
and removed
pr-awaiting-review
PR is waiting for code review
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Aug 18, 2021
bgawrych
commented
Aug 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anko-intel please take a look again
mseth10
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
and removed
pr-awaiting-review
PR is waiting for code review
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Aug 19, 2021
mseth10
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
and removed
pr-work-in-progress
PR is still work in progress
labels
Aug 20, 2021
anko-intel
approved these changes
Aug 20, 2021
bartekkuncer
approved these changes
Aug 20, 2021
mseth10
added
pr-awaiting-review
PR is waiting for code review
and removed
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Aug 20, 2021
mozga-intel
reviewed
Aug 23, 2021
mseth10
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
and removed
pr-awaiting-review
PR is waiting for code review
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Aug 23, 2021
mozga-intel
reviewed
Aug 23, 2021
mseth10
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-awaiting-review
PR is waiting for code review
and removed
pr-work-in-progress
PR is still work in progress
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Aug 24, 2021
mozga-intel
approved these changes
Aug 31, 2021
bgawrych
added a commit
to bgawrych/incubator-mxnet
that referenced
this pull request
Sep 3, 2021
* Enable brgemm based on input info * fix sanity * Review fixes * Change function name * Fix typo * Align variable assignments * Fix review * use const reference
akarbown
pushed a commit
that referenced
this pull request
Sep 6, 2021
* [v1.x][Feature] Add flag for disabling oneDNN BRGEMM implementation of FC (#20450) * Add flag for disabling oneDNN BRGEMM implementation of FC * Review fixes * Update env_var.md * [v1.x] Enabling BRGEMM FullyConnected based on shapes (#20533) * Enable brgemm based on input info * fix sanity * Review fixes * Change function name * Fix typo * Align variable assignments * Fix review * use const reference * Update flag name
bgawrych
added a commit
to bgawrych/incubator-mxnet
that referenced
this pull request
Sep 17, 2021
* Enable brgemm based on input info * fix sanity * Review fixes * Change function name * Fix typo * Align variable assignments * Fix review * use const reference
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is continuation of #20450, where enabling BRGEMM automatically was requested.
Following script was used to benchmark - only single iteration was benchmarked to avoid measuring performance with cached reordered weights for BRGEMM.
Attaching spreadsheet with results on CLX8280 (before this change).
brgemm_igemm_cmp.xlsx