Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] Restore quantized RNN operator from MXNet 1.6 #20759

Merged
merged 8 commits into from
Dec 3, 2021
Merged

[v1.x] Restore quantized RNN operator from MXNet 1.6 #20759

merged 8 commits into from
Dec 3, 2021

Conversation

bgawrych
Copy link
Contributor

Description

This PR is backport of this change: #18028
with additional refactor & bug fixes from current v1.x branch

Connected to issue: #20737

@ssriram1978
@josephevans
Test are passing, however feedback if everything works fine in your model would be appreciated

@mxnet-bot
Copy link

Hey @bgawrych , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-gpu, miscellaneous, windows-cpu, sanity, clang, website, centos-cpu, centos-gpu, unix-cpu, edge, windows-gpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Nov 26, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 26, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 26, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 27, 2021
@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu]

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Nov 29, 2021
anko-intel
anko-intel reviewed Nov 30, 2021
View reviewed changes
include/mxnet/op_attr_types.h Outdated Show resolved Hide resolved
src/operator/quantization/quantize_graph_pass.cc Outdated Show resolved Hide resolved
josephevans
josephevans approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@josephevans josephevans left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for porting this - added comments about the "Copyright by Contributors" lines (they should not be in the code.)

josephevans
josephevans reviewed Nov 30, 2021
View reviewed changes
src/operator/quantization/mkldnn/mkldnn_quantized_rnn-inl.h Outdated Show resolved Hide resolved
src/operator/quantization/mkldnn/mkldnn_quantized_rnn.cc Outdated Show resolved Hide resolved
src/operator/quantization/quantize_asym-inl.h Outdated Show resolved Hide resolved
src/operator/quantization/quantize_asym.cc Outdated Show resolved Hide resolved
src/operator/quantization/quantize_v2.cc Outdated Show resolved Hide resolved
src/operator/quantization/quantized_rnn-inl.h Outdated Show resolved Hide resolved
src/operator/quantization/quantized_rnn.cc Outdated Show resolved Hide resolved
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 1, 2021
bartekkuncer
bartekkuncer suggested changes Dec 1, 2021
View reviewed changes
src/operator/nn/mkldnn/mkldnn_rnn.cc Outdated Show resolved Hide resolved
src/operator/nn/mkldnn/mkldnn_rnn.cc Outdated Show resolved Hide resolved
src/operator/nn/mkldnn/mkldnn_rnn.cc Outdated Show resolved Hide resolved
src/operator/quantization/mkldnn/mkldnn_quantized_rnn.cc Outdated Show resolved Hide resolved
src/operator/quantization/quantize_graph_pass.cc Show resolved Hide resolved
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 2, 2021
@bgawrych
Copy link
Contributor Author

bgawrych commented Dec 2, 2021

@josephevans @bartekkuncer @anko-intel Can you take a quick look again and check if your comments was resolved?

josephevans
josephevans approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@josephevans josephevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, looks good.

@bgawrych bgawrych merged commit 8c69a9f into apache:v1.x Dec 3, 2021
josephevans pushed a commit to josephevans/mxnet that referenced this pull request Jan 11, 2022
@bgawrych @josephevans
[v1.x] Restore quantized RNN operator from MXNet 1.6 (apache#20759)
543e7b1 
* restore but seg fault

* Refactor & seg fault fixed

* apply formatter

* fix sanity

* Fix docs build

* anko review

* Remove copyright by contributors from touched files

* remove comments / apply formatter
@josephevans josephevans mentioned this pull request Jan 11, 2022
Merged
josephevans added a commit that referenced this pull request Jan 12, 2022
@josephevans @bgawrych
[v1.9.x] Port #20759 from v1.x (#20815)
0642923 
* [v1.x] Restore quantized RNN operator from MXNet 1.6 (#20759)

* restore but seg fault

* Refactor & seg fault fixed

* apply formatter

* fix sanity

* Fix docs build

* anko review

* Remove copyright by contributors from touched files

* remove comments / apply formatter

* Update call to work with older mkldnn version.

Co-authored-by: bgawrych <bartlomiej.gawrych@intel.com>
@bgawrych bgawrych mentioned this pull request Mar 10, 2022
Merged
@bgawrych bgawrych mentioned this pull request Apr 22, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephevans josephevans josephevans approved these changes

@anko-intel anko-intel anko-intel approved these changes

@bartekkuncer bartekkuncer bartekkuncer approved these changes

@anirudh2290 anirudh2290 Awaiting requested review from anirudh2290 anirudh2290 is a code owner

@eric-haibin-lin eric-haibin-lin Awaiting requested review from eric-haibin-lin eric-haibin-lin is a code owner

@szha szha Awaiting requested review from szha szha is a code owner

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bgawrych @mxnet-bot @josephevans @anko-intel @bartekkuncer @mseth10