This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[v1.9.x] Fix CD for pypi wheel version #20782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t. RELEASE_BUILD is already setup in the CD pipeline.
|
Hey @josephevans , Thanks for submitting the PR
CI supported jobs: [sanity, windows-gpu, miscellaneous, windows-cpu, clang, unix-gpu, website, edge, centos-cpu, unix-cpu, centos-gpu] Note: |
mseth10
added
the
pr-awaiting-testing
samskalicky
approved these changes
Dec 17, 2021
szha
approved these changes
Dec 17, 2021
mseth10
added
pr-work-in-progress
…ine to the docker run command.
josephevans
requested review from
aaronmarkham and
marcoabreu
as code owners
Kh4L
approved these changes
Dec 18, 2021
mseth10
removed
the
pr-awaiting-testing
josephevans
added a commit
to josephevans/mxnet
that referenced
this pull request
Dec 20, 2021
* Change env variable used to detect whether it's a release build or not. RELEASE_BUILD is already setup in the CD pipeline. * Refine how variable is compared to trigger release builds. * Check for 'true' exclusively, to prevent unwanted release builds. * Make sure we pass any environment variables on the build.py command line to the docker run command.
josephevans
added a commit
that referenced
this pull request
Dec 22, 2021
…from master (#20785) * [v1.9.x] Fix CD for pypi wheel version (#20782) * Change env variable used to detect whether it's a release build or not. RELEASE_BUILD is already setup in the CD pipeline. * Refine how variable is compared to trigger release builds. * Check for 'true' exclusively, to prevent unwanted release builds. * Make sure we pass any environment variables on the build.py command line to the docker run command. * [v1.9.x] Fix aarch64 cd pipeline (#20783) * Add wheel to installed pip packages on aarch64, so we can build the wheel in the CD pipeline. * Better support for aarch64 docker container cache. * Only import machine() function from platform module, as platform variable is already widely used. * Only build containers with aarch64 in name on aarch64. * Make all arch defaults to local machine type. * Retry getting test data to prevent CI tests from failing - increase connect timeout from 10 to 60sec, increase retry delay from 0 (setting duplicated) to 30, increase retry attempts to 5. * Update website for v1.9.x branch. (#20786) * [website] Fix broken website for master version (#19945) * fix website * fix header * fix index * remove locall test * fix main.scss Co-authored-by: Wei Chu <weichu@amazon.com> Co-authored-by: waytrue17 <52505574+waytrue17@users.noreply.github.com> Co-authored-by: Wei Chu <weichu@amazon.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CD uses "RELEASE_BUILD" variable for signifying an actual release (vs nightly.) Change the setup.py script to check for this variable, instead of "IS_RELEASE" which was not set anywhere.