This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Add cpp_package build option in CI #5844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piiswrong
reviewed
Apr 14, 2017
src/operator/tensor/matrix_op-inl.h
Outdated
| @@ -32,6 +32,10 @@ struct ReshapeParam : public dmlc::Parameter<ReshapeParam> { | |||
| DMLC_DECLARE_FIELD(shape) | |||
| .set_default(nnvm::Tuple<int>()) | |||
| .describe("The target shape"); | |||
| DMLC_DECLARE_FIELD(keep_highest).set_default(false) | |||
There was a problem hiding this comment.
dont' change this. Change code in cpp-package that's using this.
There was a problem hiding this comment.
Because keep_highest is deprecated?
|
@mli what's with the permission deny errors? I have seen them several times. http://ec2-52-25-96-65.us-west-2.compute.amazonaws.com/blue/organizations/jenkins/mxnet/detail/PR-5844/2/pipeline |
|
@mli also the CI is not picking up my changes in Jenkinsfile.. |
|
Did the Jenkinsfile take effect???
On 2017年4月17日 周一 at 20:56 Eric Junyuan Xie ***@***.***> wrote:
Merged #5844 <#5844>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5844 (comment)>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AFSeqCqry-LycGPF8C1F9ln79x0-8vxSks5rxDRigaJpZM4M-LpE>
.
--
Best Regards,
Haibin Lin
Master of Science in Computer Science
School of Computer Science
Carnegie Mellon University
+1 (412) 478-1556
www.linhaibin.com
|
|
nvm. Last time when i check the CI for this PR, it didn't pick up the CPP_PACKAGE changes. |
Guneet-Dhillon
pushed a commit
to Guneet-Dhillon/mxnet
that referenced
this pull request
Sep 13, 2017
* add cpp_package build option in CI * Change usage of Reshape in cpp-package
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cpp-package build and add it to CI build @mli
Also revert doc changes for reshape. @nswamy