Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://issues.apache.org/jira/browse/MYFACES-4699: #819

Merged
merged 1 commit into from
Dec 6, 2024
Merged

https://issues.apache.org/jira/browse/MYFACES-4699: #819

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions api/src/client/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion api/src/client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"html-webpack-plugin": "^5.5.1",
"jsdom": "^21.1.1",
"jsdom-global": "^3.0.2",
"jsf.js_next_gen": "4.0.4-beta.4",
"jsf.js_next_gen": "4.0.4-beta.5",
"mocha": "^10.2.0",
"npm-check-updates": "^16.10.8",
"nyc": "^15.1.0",
Expand Down
2 changes: 1 addition & 1 deletion api/src/client/typescript/faces/@types/definitions/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ declare global {
serverErrorName: string;
serverErrorMessage: string;
source: any;
responseCode: string;
responseCode: number;
responseText: string;
responseXML: string;
}
Expand Down
2 changes: 1 addition & 1 deletion api/src/client/typescript/faces/impl/xhrCore/ErrorData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ export class ErrorData extends EventData implements IErrorData {

//tck requires that the type is prefixed to the message itself (jsdoc also) in case of a server error
this.errorMessage = errorMessage;
this.responseCode = `${responseCode}`;
this.responseCode = responseCode;
this.responseText = responseText;
this.responseXML = responseXML;

Expand Down
4 changes: 2 additions & 2 deletions api/src/client/typescript/faces/impl/xhrCore/EventData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export class EventData implements IEventData{
type: string;
status: string;
source: any;
responseCode: string;
responseCode: number;
responseText: string;
responseXML: Document;

Expand All @@ -40,7 +40,7 @@ export class EventData implements IEventData{
}

if (name !== BEGIN) {
eventData.responseCode = request?.status?.toString();
eventData.responseCode = request?.status;
eventData.responseText = request?.responseText;
eventData.responseXML = request?.responseXML;
}
Expand Down
1 change: 1 addition & 0 deletions api/src/client/typescript/faces/test/xhrCore/RequestTest_23.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,7 @@ describe('Tests after core when it hits response', function () {
expect(!!error.errorMessage).to.eq(true);
expect(!!error.source).to.eq(true);
expect(!!error.responseCode).to.eq(true);
expect(typeof error.responseCode).to.eq("number");
expect(!!error.responseText).to.eq(true);
expect(!error.responseXML).to.eq(true);
done();
Expand Down
Loading