Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CMake project name #586

Conversation

andrzej-kaczmarek
Copy link
Contributor

This fixes project name to use both project name and target name to avoid confusion in case there are multiple projects with the same target name (e.g. CLion would list them with the same name on recent projects list).

This fixes project name to use both project name and target name to
avoid confusion in case there are multiple projects with the same target
name (e.g. CLion would list them with the same name on recent projects
list).
Copy link
Contributor

@kasjer kasjer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works great

@andrzej-kaczmarek andrzej-kaczmarek merged commit 61185b8 into apache:master Nov 26, 2024
70 checks passed
@andrzej-kaczmarek andrzej-kaczmarek deleted the resf/heads/cmake-project-name branch November 26, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants