nimble/host: add eatt opcode check in ble_eatt_l2cap_event_fn #1869
Conversation
|
#AutoPTS run mynewt GATT/SR/GAW/BV-01-C |
|
Scheduled PR #1869 (comment), board: nrf52, estimated start time: 15:24:29, test case count: 1, estimated duration: 0:01:07 Test cases to be runGATT/SR/GAW/BV-01-C |
|
#AutoPTS run mynewt GATT/SR --test_case_limit 10 |
|
Scheduled PR #1869 (comment), board: nrf52, estimated start time: 15:37:02, test case count: 10, estimated duration: 0:06:42 Test cases to be runGATT/SR/GAC/BV-01-CGATT/SR/GAC/BI-01-C GATT/SR/GAD/BV-01-C GATT/SR/GAD/BV-02-C GATT/SR/GAD/BV-03-C GATT/SR/GAD/BV-04-C GATT/SR/GAD/BV-05-C GATT/SR/GAD/BV-06-C GATT/SR/GAR/BV-01-C GATT/SR/GAR/BI-01-C |
|
AutoPTS Bot results: Successful testsGATT GATT/SR/GAW/BV-01-C PASS |
|
AutoPTS Bot results: Successful testsGATT GATT/SR/GAC/BI-01-C PASSGATT GATT/SR/GAC/BV-01-C PASS GATT GATT/SR/GAD/BV-01-C PASS GATT GATT/SR/GAD/BV-02-C PASS GATT GATT/SR/GAD/BV-03-C PASS GATT GATT/SR/GAD/BV-04-C PASS GATT GATT/SR/GAD/BV-05-C PASS GATT GATT/SR/GAD/BV-06-C PASS GATT GATT/SR/GAR/BI-01-C PASS GATT GATT/SR/GAR/BV-01-C PASS |
|
FYI @KKopyscinski |
| @@ -268,16 +268,6 @@ ble_eatt_l2cap_event_fn(struct ble_l2cap_event *event, void *arg) | |||
| opcode = event->receive.sdu_rx->om_data[0]; | |||
| if (ble_att_is_response_op(opcode)) { | |||
| ble_npl_eventq_put(ble_hs_evq_get(), &eatt->wakeup_ev); | |||
| } else if (!ble_att_is_request_op(opcode)) { | |||
| /* As per BLE 5.4 Standard, Vol. 3, Part F, section 5.3.2 | |||
There was a problem hiding this comment.
looks it was Part G.
Anyways, instead of this we should maybe extend both ble_att_is_response_op and ble_att_is_request_op so it returns depends on EATT case and satisfy below
Vol 3, Part G, 4.2
If an ATT PDU is supported on any ATT bearer, then it shall be supported on all
supported ATT bearers with the following exceptions:
• The Exchange MTU sub-procedure shall only be supported on the LE Fixed Channel
Unenhanced ATT bearer.
• The Signed Write Without Response sub-procedure shall only be supported on the LE
Fixed Channel Unenhanced ATT bearer.
piotrnarajowski
force-pushed
the
l2cap_op_check
branch
from
392b0b5
to
1cf68d3
Compare
piotrnarajowski
changed the title
|
#AutoPTS run mynewt GATT/SR/GAW/BV-01-C |
|
Scheduled PR #1869 (comment), board: nrf52, estimated start time: 12:00:35, test case count: 1, estimated duration: 0:01:09 Test cases to be runGATT/SR/GAW/BV-01-C |
|
AutoPTS Bot results: Successful tests (1)GATT GATT/SR/GAW/BV-01-C PASS |
Att opcode check caused l2cap disconnection when opcode included in received data was write command which is supported and can be used on eatt. Also, the comment seemed irrelevant. Fixes GATT/SR/GAW/BV-01-C
piotrnarajowski
force-pushed
the
l2cap_op_check
branch
from
1cf68d3
to
5a9e5ed
Compare
Att opcode check caused l2cap disconnection when opcode included in received data was write command which is supported and can be used on eatt. Also, the comment seemed irrelevant. Fixes GATT/SR/GAW/BV-01-C