Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding JavaFX sources to Ant Library #7888

Closed
trashgod opened this issue Oct 18, 2024 · 5 comments · Fixed by #7932
Closed

Adding JavaFX sources to Ant Library #7888

trashgod opened this issue Oct 18, 2024 · 5 comments · Fixed by #7932
Assignees
Labels
Ant [ci] enable "build tools" tests JavaFX [ci] enable JavaFX job kind:bug Bug report or fix

Comments

@trashgod
Copy link

Apache NetBeans version

Apache NetBeans 23

What happened

Problem: After creating a Library for JavaFX as shown in JavaFX and NetBeans: Non-modular projects: IDE and adding src.zip to the "Sources" pane of the Ant Library Manager, navigating to a source file produces a disassembled listing, as from javap -c, and the source is not available for debugging. A Maven project with downloaded sources works as expected

Mitigation: Because the Add URL… button is disabled, editing the corresponding library XML manually to use a jar URL for each module, as shown here, restores the expected navigation and debugging functionality.

<resource>jar:file:/…/lib/javafx-sdk-21.0.4/src.zip!/javafx.base/</resource>
<resource>jar:file:/…/lib/javafx-sdk-21.0.4/src.zip!/javafx.controls/</resource>
…

Language / Project Type / NetBeans Component

Java with Ant Library, Java Application

How to reproduce

  1. Download a JavaFX SDK from here; the problem may reproduced with any of several iterations of versions 21 or 17.
  2. Create a project and shown in JavaFX and NetBeans: Non-modular projects: IDE.
  3. Add the src.zip file to the "Sources" pane of the Ant Library Manager for the Library created in the previous step.
  4. Open any JavaFX program and attempt to navigate to any source class.

Did this work correctly in an earlier version?

No / Don't know

Operating System

MacOS Intel

JDK

java version "21.0.4" 2024-07-16 LTS

Apache NetBeans packaging

Apache NetBeans provided installer

Anything else

As Maven works correctly, Ant source access is a low priority issue that is easily mitigated.

Are you willing to submit a pull request?

No

@trashgod trashgod added kind:bug Bug report or fix needs:triage Requires attention from one of the committers labels Oct 18, 2024
@mbien mbien added the Ant [ci] enable "build tools" tests label Oct 19, 2024
@trashgod
Copy link
Author

Issue confirmed with javafx-sdk-21.0.5. Please consider adding JavaFX label.

@matthiasblaesing matthiasblaesing added JavaFX [ci] enable JavaFX job and removed needs:triage Requires attention from one of the committers labels Nov 1, 2024
@matthiasblaesing matthiasblaesing self-assigned this Nov 1, 2024
matthiasblaesing added a commit to matthiasblaesing/netbeans that referenced this issue Nov 1, 2024
The OpenJFX SDK and OpenJDK itself provide src.zip files, where the
source is not located at the toplevel directory, but an intermediate
level with one folder per module is used.

Closes: apache#7888
@matthiasblaesing
Copy link
Contributor

@trashgod could you please check whether #7932 fixes the issue for you? A nightly build is available from the Checkspage or directly. Thank you.

@trashgod
Copy link
Author

trashgod commented Nov 2, 2024

@matthiasblaesing: Thank you for looking at this issue. Yes, #7932 works as expected, both

  1. Via import from the previous version on initial startup, and
  2. Via the Add URL… button of the "Sources" pane.

@matthiasblaesing
Copy link
Contributor

@trashgod thanks for testing!

@trashgod trashgod closed this as completed Nov 2, 2024
@matthiasblaesing
Copy link
Contributor

Lets reopen until the fix is merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ant [ci] enable "build tools" tests JavaFX [ci] enable JavaFX job kind:bug Bug report or fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants