Cleanup the use of Float primitive wrapper. #3890
Conversation
…do a better job of handling the coversion from a float primitive to a Float Object or vice versa. This is an extension of the work done in apache#2498. No tests have been touched as those expressly need to manage the conversion.
BradWalker
added
Code cleanup
Java
|
how do you select the sub-projects you are cleaning up? I am wondering if it would be better to continue adding more commits to this PR until it is complete and all types are covered in the files you touched. So that we can review the switch blocks once instead of 8 times :) |
Hey @mbien , Most of the "rust removal" work that I do, is done to try and make it easy for a reviewer. For example, the "new Float" work this change covers should just be about Floats. I find it easier for me to make changes this way and if I had to review, it makes things easier for me to think in those terms. Changes required for the "new Double" are going to be really large (i.e. lots of different files). So that really should stand on it's own. Also, I did try and bundle together the Byte & Short changes since they were reasonable to do and review. Can I count you as an approver? 8-) BTW, hang in there.. I'm almost done.. |
|
Hey @lkishalmi , can I count you as a reviewer of this? |
There was a problem hiding this comment.
Well, this is fine for me. Also I'd rather see these PR-s as separated work even if I have to review the same case 8 times.
My only addition that it would be good to pick and use one notation instead of: 0f, 0F, 0.0F
(where, I might pick: 0.0F, as I'm old enough that my brain pick 0f or 0F as a hexadecimal number.)
As of Java 9, the VM can do a better job of handling the conversion from a float primitive to a Float Object or vice versa.
This is an extension of the work done in #2498.
No tests have been touched as those expressly need to manage the conversion.
Lastly, these changes are project wide and not module specific.
^Add meaningful description above
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
Please make sure (eg.
git log) that all commits have a valid name and email address for you in the Author field.If you're a first time contributor, see the Contributing guidelines for more information.