Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4865] Register JDPA and Java Compiler Output on Project level #4984

Merged
merged 1 commit into from
Nov 27, 2022

Conversation

lkishalmi
Copy link
Contributor

@lkishalmi lkishalmi commented Nov 18, 2022

This is a small change that registers the Gradle JDPA and JavaCompiler output listener on General Gradle project level instead of individual plugin level, so projects that non necessary Java project, but has Java sub-projects or deals with Java/JVM in some way can have their output processed.

Fixes #4865

@lkishalmi lkishalmi added the Gradle [ci] enable "build tools" tests label Nov 18, 2022
@lkishalmi lkishalmi added this to the NB17 milestone Nov 18, 2022
@lkishalmi lkishalmi requested review from mbien and sdedic November 18, 2022 14:48
@mbien
Copy link
Member

mbien commented Nov 29, 2022

@lkishalmi this PR wasn't green before merge. Its likely the one causing master to fail.

@sdedic
Copy link
Member

sdedic commented Nov 29, 2022

Yup; the JavaCompilerProcessorFactory does not handle the case the classpath is not available in the project, which is the case of umbrella / root projects without even java-base plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gradle [ci] enable "build tools" tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gradle: can't debug composite build
3 participants