Do not ask for proxies on each project. #6558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdedic
added
Gradle
mbien
approved these changes
Oct 12, 2023
lkishalmi
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementations keep user decisions per project; so if some conflict between detected proxy and detected settings is reported to the user, it is reported again for each project: but tool setings are machine-wide, so they apply to all projects.
This PR makes a simple (dirty) fix storing the decisions in a static variable, sharing between individual projects. It's really annoing if there are more projects opened. Decisions are not shared between Maven and Gradle, so the IDE may ask 2 times (once for each build system). In a typical case, the developer uses either Maven or Gradle, so hopefully this will not happen frequently.
I would like to factor the detection out to core.network + add some APIs and turn maven + gradle into just some 'setting manipulators' ... but not before NB20 branching.