Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pre-apache NetBeans 8.2 plugin portal from settings. #6991

Merged
merged 1 commit into from
Feb 10, 2024

Conversation

mbien
Copy link
Member

@mbien mbien commented Jan 24, 2024

  • the plugins haven't been updated for a long time and are of limited use, some require pack200, others broke for other reasons -> lets remove the plugin portal from the settings
  • commit contains a small language level cleanup, mostly try-with-resource blocks

there are currently 10 plugins on the old plugin portal:
image

there are currently some efforts to re-integrate CND back into NB, but this is without ETA.

closes #6810, NETBEANS-4096, NETBEANS-2719, NETBEANS-2599 (as won't-fix essentially)
related #6969, #6979, #6987

@mbien mbien added Platform [ci] enable platform tests (platform/*) ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Jan 24, 2024
@mbien mbien added this to the NB22 milestone Jan 24, 2024
@neilcsmith-net
Copy link
Member

+1 I suggested this a few years back and was vetoed. I hope there's no argument that we have no choice now.

Is the Platform label to enable something in tests? Otherwise, I'd remove it - this is almost the opposite of what we usually mean by that categorization.

@mbien mbien removed the Platform [ci] enable platform tests (platform/*) label Jan 24, 2024
@mbien
Copy link
Member Author

mbien commented Jan 24, 2024

Is the Platform label to enable something in tests? Otherwise, I'd remove it

platform label activates some extra tests which don't fit to other labels, However, I checked and the tests for this module are disabled anyway:

# - name: nb/updatecenters
# run: ant $OPTS -f nb/updatecenters test

(all tests fail locally)

removed the label

@neilcsmith-net
Copy link
Member

Ah, OK, thanks. Things like that might be better under a new label like IDE-branding or such. Anything under nb/ is quite specific to the IDE rather than the platform, so it seemed odd to label it that way. Can discuss that elsewhere as it's not relevant to this change.

Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only eyeballed this, but makes sense (code wise and based on intention).

plugins haven't been updated for a long time and are of limited use,
some require pack200, others broke for other reasons.

small language level cleanup, mostly try-with-resource blocks.
@mbien mbien removed the ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) label Feb 10, 2024
@mbien mbien force-pushed the remove-nb82-portal branch from a88ff8e to 46a55c5 Compare February 10, 2024 03:28
@mbien mbien merged commit e75fdec into apache:master Feb 10, 2024
35 checks passed
@codeNick7
Copy link

+1 for removal of Hibernate plugin as there is no much usage at this time. FYI, I am the original author of this plugin.

@mbien
Copy link
Member Author

mbien commented Feb 10, 2024

@codeNick7 awesome!

It is always a mixed feeling when something is removed, but in this case and to my understanding: the pre-apache plugin portal contained plugins which were either never donated to apache (license uncertainty) or couldn't find maintainers (the exception is CND which is work in progress). Since nothing can be rebuilt there and things start breaking, it had to go at some point.

Thanks for the comment - always great when original maintainers say hi :)

@SirFalc0n
Copy link

☹️This is bad. We need the portal for C++. Unpack200 can be found in the Java 8 JRE files.
Please put the portal back or update the heavily neglected C++ that comes by default.

@neilcsmith-net
Copy link
Member

That portal is not coming back by default! You can easily add it back in yourself, as outlined at #7627 (comment)

@apache apache locked as resolved and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hibernate Installation
5 participants