Disable FS event notifier test on mac and consolidate fs tests. #7410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like this opened another can of worms |
mbien
force-pushed
the
fix-mac-fs-tests
branch
4 times, most recently
from
5faece0 to
f2f554a
Compare
neilcsmith-net
approved these changes
Jun 6, 2024
- FSEvent order isn't predictable on mac causing frequent failures
- moved test to the core module and removed duplicates since the test
itself is platform independent
- run (now agregated) masterfs tests on all platforms (previously
only linux) and:
- disable the NotifierTest on mac
- disable all other failing tests on windows (since they didn't run
for a long time, see TODOs)
- fix some JDK sensitive tests
mbien
changed the title
|
refreshed PR, going to merge once green again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NotifierTeston macthe test failures are getting annoying. Discussed this with @neilcsmith-net via slack a while ago to turn the test on mac off, some resources:
NB Notifier service provider order is currently: https://github.com/search?q=repo%3Aapache%2Fnetbeans%20%40ServiceProvider(service%3DNotifier.class&type=code
last time things were changed: #1349, #1935
which means: