Instruct users on setting up cloud resources when opening SSH session and running container image #7607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrovic-d
force-pushed
the
instruct-user-to-set-cloud-resources
branch
from
1a06579 to
e12b4eb
Compare
sdedic
requested changes
Jul 30, 2024
jhorvath
added
Need Squashing
enterprise
petrovic-d
force-pushed
the
instruct-user-to-set-cloud-resources
branch
from
29d4f03 to
6a113fb
Compare
|
fyi: gh CI is currently having issues, requests don't get runners assigned looks like. (https://www.githubstatus.com/) |
petrovic-d
force-pushed
the
instruct-user-to-set-cloud-resources
branch
from
6a113fb to
15801de
Compare
sdedic
approved these changes
Jul 31, 2024
| }); | ||
| } | ||
|
|
||
| async messageHandler(message: any): Promise<void> { |
There was a problem hiding this comment.
Just a suggestion: given that superclass has getSource that assumes current guide's style (subclasses can override), the same principle may be used with messageHandler stock implementation: can be moved to the base class; if other javascript than guide.js is returned from getSources() it can use a differet msg command and an appropriate subclass can handle it.
There was a problem hiding this comment.
I was thinking about it, but then parent GuidePanel.ts becomes aware of specific properties that are passed to it
… and running container image
petrovic-d
force-pushed
the
instruct-user-to-set-cloud-resources
branch
from
15801de to
2383962
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instruct users on setting up cloud resources when opening SSH session and running container image.
Guide will be shown for the first time command is used for a given instance identified by an OCID.