-
Notifications
You must be signed in to change notification settings - Fork 866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloud Assets - build and push docker command #7642
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhorvath
added
LSP
[ci] enable Language Server Protocol tests
VSCode Extension
[ci] enable VSCode Extension tests
enterprise
[ci] enable enterprise job
labels
Aug 6, 2024
jhorvath
force-pushed
the
build-docker-oci
branch
7 times, most recently
from
August 7, 2024 10:14
a2e739b
to
f92d23e
Compare
jhorvath
force-pushed
the
build-docker-oci
branch
2 times, most recently
from
August 8, 2024 14:20
4bbcd0b
to
be66ced
Compare
sdedic
requested changes
Aug 9, 2024
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/assets/CloudAssets.java
Outdated
Show resolved
Hide resolved
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/assets/ImageBuilderCommand.java
Outdated
Show resolved
Hide resolved
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/assets/ImageBuilderCommand.java
Outdated
Show resolved
Hide resolved
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/assets/ImageBuilderCommand.java
Outdated
Show resolved
Hide resolved
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/assets/ImageBuilderCommand.java
Outdated
Show resolved
Hide resolved
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/assets/ImageBuilderCommand.java
Outdated
Show resolved
Hide resolved
platform/libs.javax.inject/src/org/netbeans/libs/javax/Dummy.java
Outdated
Show resolved
Hide resolved
jhorvath
force-pushed
the
build-docker-oci
branch
from
August 14, 2024 12:27
be66ced
to
21f00e7
Compare
sdedic
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems OK.
As this adds a new module, I'll re-run the tests with ci:all
so everything is built / tested
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/assets/ImageBuilderCommand.java
Outdated
Show resolved
Hide resolved
jhorvath
force-pushed
the
build-docker-oci
branch
from
August 15, 2024 14:38
21f00e7
to
2c01004
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci:all-tests
[ci] enable all tests
enterprise
[ci] enable enterprise job
LSP
[ci] enable Language Server Protocol tests
VSCode Extension
[ci] enable VSCode Extension tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a command to build and push the Docker image to a selected repository. I cleaned up the dependencies of maven.indexer. Note that javax.inject is now in a separate module within the platform cluster.