Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud Assets - build and push docker command #7642

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

jhorvath
Copy link
Contributor

@jhorvath jhorvath commented Aug 6, 2024

Added a command to build and push the Docker image to a selected repository. I cleaned up the dependencies of maven.indexer. Note that javax.inject is now in a separate module within the platform cluster.

@jhorvath jhorvath added LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests enterprise [ci] enable enterprise job labels Aug 6, 2024
@jhorvath jhorvath requested review from mbien and sdedic August 6, 2024 13:01
@jhorvath jhorvath self-assigned this Aug 6, 2024
@jhorvath jhorvath force-pushed the build-docker-oci branch 7 times, most recently from a2e739b to f92d23e Compare August 7, 2024 10:14
@ebarboni ebarboni added this to the NB24 milestone Aug 7, 2024
@jhorvath jhorvath force-pushed the build-docker-oci branch 2 times, most recently from 4bbcd0b to be66ced Compare August 8, 2024 14:20
@jhorvath jhorvath requested a review from sdedic August 15, 2024 08:10
@apache apache locked and limited conversation to collaborators Aug 15, 2024
@apache apache unlocked this conversation Aug 15, 2024
Copy link
Member

@sdedic sdedic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK.
As this adds a new module, I'll re-run the tests with ci:all so everything is built / tested

@sdedic sdedic added the ci:all-tests [ci] enable all tests label Aug 15, 2024
@apache apache locked and limited conversation to collaborators Aug 15, 2024
@apache apache unlocked this conversation Aug 15, 2024
@jhorvath jhorvath merged commit 36171a7 into apache:master Aug 16, 2024
40 checks passed
@jhorvath jhorvath deleted the build-docker-oci branch August 16, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:all-tests [ci] enable all tests enterprise [ci] enable enterprise job LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants