Delete action for Container Repository Images and Vault Secrets #7649
Conversation
jhorvath
added
LSP
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/actions/DeleteNodeAction.java
Outdated
Show resolved
Hide resolved
| @@ -101,6 +103,11 @@ public TreeItemData createDecorations(Node n, boolean expanded) { | |||
| d.addContextValues(CTXVALUE_CAP_REFERENCE_NAME); | |||
| set = true; | |||
| } | |||
|
|
|||
| if (item instanceof SecretItem) { | |||
There was a problem hiding this comment.
@jhorvath these interface-dependent extractions ("if X in Lookup, use put "prefix:${X.property}" into contextValue) seem rather common / useful ... if the usage will grow, we could invent a declarative support for that, would be then far easier to export state to LSP clients.
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/vault/SecretNode.java
Show resolved
Hide resolved
|
The DeleteNodeAction should not be implemented at all. There is already support for deletion. The context value cap:delete is added when Node.canDestroy() returns true in DefaultDecorationsImpl. Additionally, destroy() is called in LspTreeViewServiceImpl for the delete command, which should appear automatically based on the context value. |
petrovic-d
force-pushed
the
delete-cloud-assets-command
branch
2 times, most recently
from
9804941 to
3b916c4
Compare
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/NotificationUtils.java
Outdated
Show resolved
Hide resolved
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/OCINode.java
Show resolved
Hide resolved
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/vault/SecretNode.java
Outdated
Show resolved
Hide resolved
petrovic-d
force-pushed
the
delete-cloud-assets-command
branch
from
3b916c4 to
086ad44
Compare
|
|
||
| @Override | ||
| public void destroy() throws IOException { | ||
| ArtifactsClient client = OCIManager.getDefault().getActiveSession().newClient(ArtifactsClient.class); |
There was a problem hiding this comment.
Lengthy operation cannot be executed inside destroy(). You have use RequestProcessor here
| "DeleteNodeAction=Delete item", | ||
| "MSG_ConfirmDeleteAction=Are you sure that you want to delete {0}", | ||
| "MSG_DeleteActionFailed=Failed to delete {0}.", | ||
| "MSG_DeleteActionSuccess=Successfully deleted {0}." |
There was a problem hiding this comment.
This message is not accurate for scheduled deletions. You should display a different message specifically for scheduled deletions and consider making it more general, as other special cases might arise in the future.
|
|
||
| @Override | ||
| public void destroy() throws IOException { | ||
| RequestProcessor.getDefault().post(() -> { |
There was a problem hiding this comment.
Please don't use default RP. Create a dedicated one for this class with throughput 1 like this:
RequestProcessor RP = new RequestProcessor(ContainerTagNode.class);
Action for deleting Container Repository Images and Vault Secrets.
Since there is no API to instantly delete Vault Secrets, the deletion is scheduled for tomorrow. Also Cloud Asset view now shows if Vault Secret is in state: PENDING_DELETION