Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support annotation processor dependencies #7679

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

sdedic
Copy link
Member

@sdedic sdedic commented Aug 16, 2024

The PR improves implementation of project dependencies (private) API to handle PROCESS scope. It works for gradle, since the annotationProcessor scope is the same as other ones ... but did not work for Maven.
Now the implementation is (still with some limitations) able to enumerate annotation processor paths from maven and also add items to it.

@sdedic sdedic added Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) Gradle [ci] enable "build tools" tests LSP [ci] enable Language Server Protocol tests Maven [ci] enable "build tools" tests labels Aug 16, 2024
@sdedic sdedic added this to the NB24 milestone Aug 16, 2024
@sdedic sdedic self-assigned this Aug 16, 2024
@sdedic sdedic requested a review from jhorvath August 16, 2024 14:25
@sdedic sdedic force-pushed the projects/deps-annotation-processors branch from 55291ee to d631c43 Compare August 16, 2024 15:00
@sdedic sdedic requested review from lahodaj and MartinBalin August 16, 2024 17:51
@sdedic sdedic requested a review from dbalek August 26, 2024 08:36
Copy link
Contributor

@dbalek dbalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane.

@sdedic sdedic merged commit effcb4f into apache:master Aug 26, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gradle [ci] enable "build tools" tests Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) LSP [ci] enable Language Server Protocol tests Maven [ci] enable "build tools" tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants