Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for string[] vmArgs #7697

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

sdedic
Copy link
Member

@sdedic sdedic commented Aug 26, 2024

The launch config vmParameters is quite often composed from several parameters. While it is convenient to write one string, as the number of parameters grows, or parameters are "fancy" (contain spaces, quotes, ...), it may be better to express them as an array.

MS Java extension also allows to configure vmargs as an array, so this addition may make user migration to NBLS or extension switching easier.

@sdedic sdedic added Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) VSCode Extension [ci] enable VSCode Extension tests labels Aug 26, 2024
@sdedic sdedic added this to the NB24 milestone Aug 26, 2024
@sdedic sdedic self-assigned this Aug 26, 2024
@sdedic sdedic requested a review from lahodaj August 26, 2024 14:48
Copy link
Contributor

@lahodaj lahodaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@sdedic sdedic merged commit f59beaf into apache:master Aug 28, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) VSCode Extension [ci] enable VSCode Extension tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants