Copy application config file before docker run #7698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhorvath
added
LSP
sdedic
reviewed
Aug 28, 2024
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/assets/ConfigFileGenerator.java
Outdated
Show resolved
Hide resolved
| public Path generateConfigFile() throws IOException { | ||
| Path dir = generateDirPath(); | ||
|
|
||
| if (!Files.isDirectory(dir, LinkOption.NOFOLLOW_LINKS)) { |
There was a problem hiding this comment.
Q: what will be the result if there's a symbolic link named ${dir} ?
There was a problem hiding this comment.
The if statement will return true and then line below will throw exception...
Maybe I could add a check before this if it is symlink, and delete it in that case?
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/assets/ConfigFileGenerator.java
Outdated
Show resolved
Hide resolved
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/assets/ConfigFileGenerator.java
Outdated
Show resolved
Hide resolved
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/assets/ConfigFileGenerator.java
Outdated
Show resolved
Hide resolved
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/assets/OCIPropertiesProvider.java
Outdated
Show resolved
Hide resolved
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/assets/ConfigFileProvider.java
Outdated
Show resolved
Hide resolved
petrovic-d
force-pushed
the
copy-config-files-before-docker-run
branch
from
aa3af86 to
f11f4b3
Compare
jhorvath
reviewed
Aug 30, 2024
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/assets/ConfigFileProvider.java
Outdated
Show resolved
Hide resolved
petrovic-d
force-pushed
the
copy-config-files-before-docker-run
branch
2 times, most recently
from
56e6ea0 to
b099be2
Compare
sdedic
reviewed
Sep 2, 2024
enterprise/cloud.oracle/src/org/netbeans/modules/cloud/oracle/assets/ConfigFileProvider.java
Outdated
Show resolved
Hide resolved
sdedic
reviewed
Sep 2, 2024
petrovic-d
force-pushed
the
copy-config-files-before-docker-run
branch
from
b099be2 to
957334c
Compare
petrovic-d
force-pushed
the
copy-config-files-before-docker-run
branch
from
957334c to
04b4884
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When run docker image in compute instance command is invoked, before actually running the image, configuration file will be uploaded to the compute instance and later it would be mounted as a volume so that application is provided with the properties. Properties are generated with PropertiesGenerator