Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Organize-imports can sometimes add unwanted imports #7699

Merged
merged 1 commit into from
Aug 29, 2024
Merged

fix: Organize-imports can sometimes add unwanted imports #7699

merged 1 commit into from
Aug 29, 2024

Conversation

subhash-arabhi
Copy link
Contributor

Changes to fix the bug. This PR created this side effect.

Brief

When there is a name clash in our package with java.lang.*, the addImports function from GeneratorUtilities is adding unwanted package imports. Refer bug for more details

@mbien mbien added the Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) label Aug 27, 2024
@mbien mbien added this to the NB24 milestone Aug 27, 2024
mbien
mbien reviewed Aug 27, 2024
View reviewed changes
Copy link
Member

@mbien mbien left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me, thanks!

(had a deja-vu since I thought I fixed this already #7363, but this is a different edge case and also a different action: fix imports vs organize imports)

could you squash the two commits?

@mbien mbien changed the title Unwanted imports bug fix: Organize-imports can sometimes create unwanted imports Aug 27, 2024
@mbien mbien changed the title fix: Organize-imports can sometimes create unwanted imports fix: Organize-imports can sometimes add unwanted imports Aug 27, 2024
@mbien mbien added ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Need Squashing labels Aug 28, 2024
@subhash-arabhi
Removing unwanted package imports
9b6efe6 
Signed-off-by: Subhash Arabhi <subhashsubbu636@gmail.com>

Tests for changes in addImports function

Signed-off-by: Subhash Arabhi <subhashsubbu636@gmail.com>
@subhash-arabhi
Copy link
Contributor Author

makes sense to me, thanks!

(had a deja-vu since I thought I fixed this already #7363, but this is a different edge case and also a different action: fix imports vs organize imports)

could you squash the two commits?

@mbien I have squashed the commits, could you approve and merge this PR

mbien
mbien approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for squashing

@mbien mbien merged commit 2455ae4 into apache:master Aug 29, 2024
36 checks passed
@subhash-arabhi subhash-arabhi mentioned this pull request Sep 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbien mbien mbien approved these changes

Assignees
No one assigned
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form)
Projects
None yet
Milestone
NB24
Development

Successfully merging this pull request may close these issues.
2 participants
@subhash-arabhi @mbien