Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added metrics support for Cloud Assets #7700

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Added metrics support for Cloud Assets #7700

merged 1 commit into from
Sep 3, 2024

Conversation

petrovic-d
Copy link
Collaborator

Added support for adding metrics namespace to Cloud Assets view

  • Suggests to add metrics namespace to Cloud Assets when appropriate dependency is found
  • When added to Cloud Assets view it will add dependency and annotation processor for metrics support
  • When expanding metrics namespace it will show individual metrics with option to open external link to OCI Console
  • If added to Cloud Assets, Create External Config command will now generate config for selected metrics namespace

@jhorvath jhorvath requested a review from sdedic August 27, 2024 08:37
@jhorvath jhorvath added this to the NB24 milestone Aug 27, 2024
@jhorvath jhorvath added LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests enterprise [ci] enable enterprise job labels Aug 27, 2024
@petrovic-d petrovic-d force-pushed the cloud-assets-oci-metrics-support branch from df7d776 to 8c46e1b Compare August 29, 2024 13:38
@petrovic-d petrovic-d requested a review from sdedic August 29, 2024 13:38
@sdedic
Copy link
Member

sdedic commented Aug 29, 2024

@petrovic-d:

enterprise/cloud.oracle/external/oci-java-sdk-monitoring-3.25.3.jar is not associated with any license file

@petrovic-d petrovic-d force-pushed the cloud-assets-oci-metrics-support branch from 8c46e1b to d218baf Compare August 30, 2024 08:34
@petrovic-d petrovic-d force-pushed the cloud-assets-oci-metrics-support branch from d218baf to 6a89602 Compare August 30, 2024 11:53
jhorvath
jhorvath approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@jhorvath jhorvath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jhorvath jhorvath merged commit fa14a85 into apache:master Sep 3, 2024
32 checks passed
@jhorvath jhorvath deleted the cloud-assets-oci-metrics-support branch September 3, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinBalin MartinBalin MartinBalin approved these changes

@jhorvath jhorvath jhorvath approved these changes

@sdedic sdedic Awaiting requested review from sdedic

Assignees

@petrovic-d petrovic-d

Labels
enterprise [ci] enable enterprise job LSP [ci] enable Language Server Protocol tests VSCode Extension [ci] enable VSCode Extension tests
Projects
None yet
Milestone
NB24
Development

Successfully merging this pull request may close these issues.
4 participants
@petrovic-d @sdedic @jhorvath @MartinBalin