Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test window for multi-module maven projects #7728

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

mbien
Copy link
Member

@mbien mbien commented Sep 4, 2024

check the reports directory of the sub project instead of the root project if the information is available in the context.

symptom:
When a project with maven modules is built, no sub-project test results are shown in the test window, even though the tab opens. Building the sub project directly however would show results.

check the reports directory of the sub project instead of the root
project if the information is available in the context.
@mbien mbien added Maven [ci] enable "build tools" tests ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Sep 4, 2024
@mbien mbien added this to the NB24 milestone Sep 4, 2024
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks sane to me. I assume, that this is intended for #7710?

Did a quick check with a multi-module maven project and could reproduce the issue with surefire 2.19+ (tested with 2.22) and found it fixed with this changeset.

Thank you.

@mbien
Copy link
Member Author

mbien commented Sep 4, 2024

Change looks sane to me. I assume, that this is intended for #7710?

i am actually not sure, would be worth asking if this does resolve the issue too, the symptoms do not completely align. I noticed the multi-module test window issue while building mvnd recently.

edit: issue is not connected to this fix here

@mbien
Copy link
Member Author

mbien commented Sep 5, 2024

@matthiasblaesing btw I thought about targeting NB 23, but there is a chance that the info in the visitor context isn't always correct, so this could cause failures in different places. I don't want to take the risk right now so late in the release cycle.

@mbien
Copy link
Member Author

mbien commented Sep 5, 2024

so I thought about this and I believe that this should probably cause no problems since:

@matthiasblaesing so I am going to rebase this for delivery, if you think this is ok for NB23 too, please let me know, otherwise i can put it back to NB24 no problem.

@mbien mbien changed the base branch from master to delivery September 5, 2024 23:46
@mbien mbien force-pushed the mvn-submodule-testwindow-fix branch from 7ecdbc4 to 5f43473 Compare September 5, 2024 23:46
@mbien mbien removed this from the NB24 milestone Sep 5, 2024
@ebarboni
Copy link
Contributor

ebarboni commented Sep 6, 2024

LGTM

@ebarboni ebarboni added this to the NB23 milestone Sep 6, 2024
@MartinBalin
Copy link
Contributor

Not for release 23, too late and it is not a showstopper.

@mbien
Copy link
Member Author

mbien commented Sep 6, 2024

Not for release 23, too late and it is not a showstopper.

thanks! going to retarget it again later.

@mbien mbien modified the milestones: NB23, NB24 Sep 6, 2024
@mbien mbien added the do not merge Don't merge this PR, it is not ready or just demonstration purposes. label Sep 6, 2024
@mbien mbien changed the base branch from delivery to master September 6, 2024 14:28
@mbien mbien force-pushed the mvn-submodule-testwindow-fix branch from 5f43473 to 7ecdbc4 Compare September 6, 2024 14:29
@mbien mbien removed the do not merge Don't merge this PR, it is not ready or just demonstration purposes. label Sep 6, 2024
@mbien
Copy link
Member Author

mbien commented Sep 6, 2024

pushed the old branch again, retargeted to master. Going to merge it soon for NB 24.

thanks for reviews + delivery triaging

@mbien mbien merged commit 4c81ffe into apache:master Sep 7, 2024
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Maven [ci] enable "build tools" tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants