-
Notifications
You must be signed in to change notification settings - Fork 865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test window for multi-module maven projects #7728
Conversation
check the reports directory of the sub project instead of the root project if the information is available in the context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks sane to me. I assume, that this is intended for #7710?
Did a quick check with a multi-module maven project and could reproduce the issue with surefire 2.19+ (tested with 2.22) and found it fixed with this changeset.
Thank you.
i am actually not sure, would be worth asking if this does resolve the issue too, the symptoms do not completely align. I noticed the multi-module test window issue while building mvnd recently. edit: issue is not connected to this fix here |
@matthiasblaesing btw I thought about targeting NB 23, but there is a chance that the info in the visitor context isn't always correct, so this could cause failures in different places. I don't want to take the risk right now so late in the release cycle. |
so I thought about this and I believe that this should probably cause no problems since:
@matthiasblaesing so I am going to rebase this for delivery, if you think this is ok for NB23 too, please let me know, otherwise i can put it back to NB24 no problem. |
7ecdbc4
to
5f43473
Compare
LGTM |
Not for release 23, too late and it is not a showstopper. |
thanks! going to retarget it again later. |
5f43473
to
7ecdbc4
Compare
pushed the old branch again, retargeted to master. Going to merge it soon for NB 24. thanks for reviews + delivery triaging |
check the reports directory of the sub project instead of the root project if the information is available in the context.
symptom:
When a project with maven modules is built, no sub-project test results are shown in the test window, even though the tab opens. Building the sub project directly however would show results.